Merge pull request #200 from kwuerl/master

Fix for memleak and curl_close() never being called
WordPress · Apr 19, 2016 · b998001 · b998001
2 parents 12173db + faa4d04
commit b998001
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/library/Requests/Transport/cURL.php b/library/Requests/Transport/cURL.php
@@ -176,6 +176,11 @@ public function request($url, $headers = array(), $data = array(), $options = ar
 
 		$this->process_response($response, $options);
 
+		// Need to remove the $this reference from the curl handle. 
+		// Otherwise Requests_Transport_cURL wont be garbage collected and the curl_close() will never be called.
+		curl_setopt($this->handle, CURLOPT_HEADERFUNCTION, null);
+		curl_setopt($this->handle, CURLOPT_WRITEFUNCTION, null);
+
 		return $this->headers;
 	}