Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility audit for 2024 theme #2482

Closed
6 tasks done
adamwoodnz opened this issue May 31, 2024 · 8 comments · Fixed by #2750
Closed
6 tasks done

Accessibility audit for 2024 theme #2482

adamwoodnz opened this issue May 31, 2024 · 8 comments · Fixed by #2750
Assignees
Labels
Accessibility Fix or enhancement related to accessibility. [Component] Learn Theme Website development issues related to the Learn theme. Dev

Comments

@adamwoodnz
Copy link
Contributor

adamwoodnz commented May 31, 2024

  • Run scans
  • Test with keyboard
  • Test with Voiceover
  • Test with JAWS/NVDA
  • Log issues in comments below
  • Fix issues
@adamwoodnz adamwoodnz converted this from a draft issue May 31, 2024
@adamwoodnz adamwoodnz added [Component] Learn Theme Website development issues related to the Learn theme. Accessibility Fix or enhancement related to accessibility. Dev labels May 31, 2024
@adamwoodnz adamwoodnz added this to the Learning Pathways launch milestone May 31, 2024
@adamwoodnz adamwoodnz self-assigned this Jun 20, 2024
@adamwoodnz
Copy link
Contributor Author

adamwoodnz commented Jun 21, 2024

The search field is within the main landmark on a lot of templates. This should only be the case on the search results page where it is the main functionality. Otherwise it should be above.

@adamwoodnz adamwoodnz moved this from ⚠ On Hold/Blocked to 🏗 In progress in WordPress.org Redesign Jun 21, 2024
@adamwoodnz adamwoodnz moved this from 🏗 In progress to ⚠ On Hold/Blocked in WordPress.org Redesign Jun 25, 2024
@adamwoodnz adamwoodnz moved this from ⚠ On Hold/Blocked to 📋 To do in WordPress.org Redesign Jul 9, 2024
@adamwoodnz adamwoodnz removed their assignment Jul 9, 2024
@adamwoodnz
Copy link
Contributor Author

See if this is still an issue with the new theme WordPress/wporg-mu-plugins#644

@adamwoodnz
Copy link
Contributor Author

adamwoodnz commented Jul 22, 2024

Average a11y scores from automated lighthouse scans are good:

Image

Top line is the existing site. Lessons archive doesn't show any issues when manually scanned.

@adamwoodnz adamwoodnz moved this from 📋 To do to 🏗 In progress in WordPress.org Redesign Jul 23, 2024
@adamwoodnz
Copy link
Contributor Author

Fallback featured image has no alt text

Screenshot 2024-07-24 at 1 12 37 PM

@adamwoodnz
Copy link
Contributor Author

My Courses card progress bar needs accessible name

Screenshot 2024-07-24 at 1 16 29 PM

@adamwoodnz adamwoodnz changed the title Accessibility audit Accessibility audit for 2024 theme Jul 24, 2024
@adamwoodnz
Copy link
Contributor Author

adamwoodnz commented Jul 24, 2024

'See all' links don't provide context to screen readers. Should be read as 'See all intermediate learning pathways for WordPress users'

Screenshot 2024-07-24 at 2 26 20 PM

@adamwoodnz
Copy link
Contributor Author

adamwoodnz commented Jul 24, 2024

The search field is within the main landmark on a lot of templates. This should only be the case on the search results page where it is the main functionality. Otherwise it should be above.

This is only an issue on the archive pages, where the order of elements is:

  1. h1
  2. intro paragraph
  3. search and filters
  4. content (list of courses displayed as cards)

Screenshot 2024-07-24 at 4 46 33 PM

Currently all of this is within the main landmark. On a regular 'single' type document page typically the h1, intro paragraph and content would be in main, with a search field above. However in this case searching and filtering the archive is the core functionality of the page, so it makes sense for them to be located within main with the cards.

adamwoodnz added a commit that referenced this issue Jul 24, 2024
…#2750)

* Add a block to enhance the sensei progress bars by adding aria labels

See #2482

* Remove unused classname on course sidebar progress bar
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in WordPress.org Redesign Jul 24, 2024
@joedolson
Copy link

In the course cards, all links are duplicated.

image

While this doesn't cause any immediate problems, it does mean that the travel path is significantly longer for keyboard and screen reader users, and creates a lot of redundancy in navigating course archives. It would be better if these two elements were combined into a single link & the alt text was empty on the image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility Fix or enhancement related to accessibility. [Component] Learn Theme Website development issues related to the Learn theme. Dev
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants