Code of conduct test #157
Merged
Code of conduct test #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ann-kilzer
reviewed
Jun 29, 2025
Collaborator
ann-kilzer
left a comment
ann-kilzer
left a comment
There was a problem hiding this comment.
With our tests, let's really think about what kind of failures we might see as the code changes over time. This page relies heavily on i18n and translations, so it would be good to see some assertions around the body text showing up correctly. We don't need to check every single word, but ensuring a few key sentences appear would improve confidence.
Bonus points if you are able to ensure that the text appears in both Japanese and English
sirbully
commented
Aug 11, 2025
Comment on lines
+57
to
+62
| // FIXME: The other headings are have not been translated yet, testing the English headings for now | ||
| expect(headings[1]).toHaveTextContent('Women in Software Engineering Japan Statement of Intent') | ||
| expect(headings[2]).toHaveTextContent('Code of Conduct for Women in Software Engineering Japan Events') | ||
| expect(headings[3]).toHaveTextContent('How to Report Harassment and Discrimination') | ||
| expect(headings[4]).toHaveTextContent('Periodic Review') | ||
| }) |
Contributor
Author
There was a problem hiding this comment.
as mentioned in the FIXME, no translations for this yet, perhaps it can be addressed in a separate PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #98
What changed 🧐
Added code of conduct component test
How did you test it? 🧪
Check if the Code of Conduct is rendered properly.