Skip to content

fmt(js): npm run fix auto-fix - #10

Closed
github-actions[bot] wants to merge 1 commit into
mainfrom
bot/js-autofix
Closed

fmt(js): npm run fix auto-fix#10
github-actions[bot] wants to merge 1 commit into
mainfrom
bot/js-autofix

Conversation

@github-actions

@github-actions github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown

Auto-generated by the auto-fix lint issues & formatting workflow. Auto-merges (squash) once CI passes. If CI fails or main moves, the PR is auto-closed and the branch deleted — the next run re-applies on the current state.


Open in Devin Review

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 2 potential issues.

Open in Devin Review

Comment on lines 122 to +127
overlay.modelPicker ||
overlay.pager ||
overlay.petPicker ||
overlay.pluginsHub ||
overlay.sessions ||
overlay.skillsHub
overlay.pager ||
overlay.petPicker ||
overlay.pluginsHub ||
overlay.sessions ||
overlay.skillsHub

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Deindented boolean chain in hasFloatingPanel is not prettier-idiomatic

The reformat drops the continuation indentation on the || chain inside Boolean(...), which is unusual output for Prettier (the surrounding $isBlocked computed at ui-tui/src/app/overlayStore.ts:49-66 uses the same flat style, so it is at least internally consistent). Behavior is unchanged; worth a sanity check that the TUI package's formatter config (e.g. a custom printWidth or a non-Prettier formatter) is what produced this, so the next npm run fix doesn't oscillate the file back and forth.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Comment on lines 1 to +2
export type RightPanePerfEvent =
| 'project-tree-render'
| 'project-tree-row-render'
| 'terminal-fit-active'
| 'terminal-fit-hidden'
| 'terminal-measure'
'project-tree-render' | 'project-tree-row-render' | 'terminal-fit-active' | 'terminal-fit-hidden' | 'terminal-measure'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Info: Union type collapsed onto one line exceeds the usual readability threshold

RightPanePerfEvent is now a single 120-char union line instead of the leading-pipe multi-line form. Purely cosmetic and semantically identical, but adding a sixth member will re-wrap the whole declaration, producing noisy diffs. Same shape appears in the reformatted cast at ui-tui/src/__tests__/scrollBoxRendererBounds.test.ts:385-386.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

@WolframRavenwolf
WolframRavenwolf deleted the bot/js-autofix branch August 10, 2026 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant