MrEngineer02 dhcp fixes #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 16, 2018 20:16
Per Wiznet/ioLibrary_Driver#35 the MAGIC_COOKIE should not be modified. Updated the comment to make it clearer.
Per Wiznet/ioLibrary_Driver#23 the DHCP host name needs to be ASCII chars. This was actually fixed in WIZ550S2E, but was overwritten when the ioLibrary was merged at r1.1.0. Bringing back the original fix, which uses sprintf to create valid names. Spelling fixes Removed duplicate call to setSIPR(zeroip); as per Wiznet/ioLibrary_Driver#45
Removed duplicate call to setSIPR(zeroip);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See comments for each file