Merge pull request #336 from Wixel/fix-328

Fixes #328
Wixel · Jul 15, 2022 · 8de017f · 8de017f
2 parents 03050d9 + 8a69490
commit 8de017f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/gump.class.php b/gump.class.php
@@ -1887,11 +1887,9 @@ protected function validate_regex($field, array $input, array $params = [], $val
      */
     protected function validate_valid_json_string($field, array $input, array $params = [], $value = null)
     {
-        if (!is_string($input[$field]) || !is_object(json_decode($value))) {
-            return false;
-        }
-
-        return true;
+         return is_string($input[$field])
+             && is_array(json_decode($value, true))
+             && (json_last_error() == JSON_ERROR_NONE);
     }
 
     /**

diff --git a/tests/Validators/ValidJsonStringValidatorTest.php b/tests/Validators/ValidJsonStringValidatorTest.php
@@ -28,6 +28,7 @@ public function successProvider()
         return [
             ['{}'],
             ['{"testing": true}'],
+            ['["one", "two"]'],
         ];
     }
 
@@ -52,4 +53,4 @@ public function testWhenInputIsEmptyAndNotRequiredIsSuccess()
     {
          $this->assertTrue($this->validate(self::RULE, ''));
     }
-}
+}