refactor: remove dead connect_dual_stack and try_connect_family methods

[mickvandijke]

Summary

• Remove unused connect_dual_stack and try_connect_family methods from P2pEndpoint
• Remove now-unused IpAddr import from p2p_endpoint.rs
• These methods were dead code — dual-stack connectivity is handled elsewhere in the connection establishment flow

Test plan

• cargo check --all-targets passes
• cargo nextest run passes (no tests referenced these methods)

🤖 Generated with Claude Code

Greptile Summary

This PR removes two dead code methods — connect_dual_stack and try_connect_family — from P2pEndpoint, along with the now-unused IpAddr import. A full-repo search confirms no callers existed anywhere in the codebase; dual-stack connectivity is already handled by connect_with_fallback.

Confidence Score: 5/5

Safe to merge — pure dead-code removal with no remaining references and no behavioral change.

All changes are removal of unreferenced methods and an unused import. A full-repo grep confirms zero callers exist, so there is no risk of regression.

No files require special attention.

Important Files Changed

Filename	Overview
src/p2p_endpoint.rs	Removes dead connect_dual_stack and try_connect_family methods and the unused IpAddr import; no remaining references found anywhere in the repo.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[connect_with_fallback] --> B[Direct IPv4]
    A --> C[Direct IPv6]
    A --> D[Hole-Punch]
    A --> E[Relay]
    F[connect_dual_stack - REMOVED] -.->|was dead code| A
    G[try_connect_family - REMOVED] -.->|was dead code| F

Loading

_{Reviews (1): Last reviewed commit: "refactor: remove dead connect_dual_stack..." | Re-trigger Greptile}

[github-actions]

Benchmark Results

Performance Comparison

Benchmark	Baseline	Current	Change	Status

Summary

Configuration

• Regression threshold: >10% slower
• Improvement threshold: >10% faster
• Measurements: Mean execution time