-
Notifications
You must be signed in to change notification settings - Fork 6
feat: node discovery and much more #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
84ea902
feat: node discovery and much more
grumbach 6ba6ebe
fix: address PR #16 review feedback
grumbach 0e304be
docs: clarify adaptive-ml feature is optional with fallbacks
grumbach 0c38bce
fix: gate adaptive tests with feature flag, align DHT value size with…
grumbach 98e7ac4
ci: add adaptive-ml feature to test workflows
grumbach 6d504c3
fix: standardize trust NodeId derivation to match DHT peer selection
mickvandijke 736fab1
ci: restrict adaptive-ml feature to EigenTrust test only
mickvandijke cc39b86
ci: restrict adaptive-ml to gossipsub/coordinator tests in network wo…
mickvandijke 68e46c9
fix: deduplicate keys in prop_expired_records_not_returned to fix fla…
mickvandijke 0337f76
fix: remove redundant outer timeout in retrieve() to prevent pending_…
mickvandijke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making adaptive-ml a required default feature contradicts the earlier feature organization that shows it as 'Experimental Features (not production-wired yet)'. If this is truly required for compilation, it should not be in the experimental section and should not be optional. This creates confusion about the stability status. Either make it truly optional with proper feature gates, or move it out of the experimental section.