Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CLOCK_BOOTTIME also for amd64's time.now() in Go runtime #71

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mateusz-markowicz
Copy link

This change was missing in the original patch causing issues with GoLang time functions on chromebooks after device wakes up from sleep and leading to failed connections.

After running below code on Chromebook after it was sleeping since boot

timestamp := time.Now()
elapsed := time.Since(timestamp)

elapsed will have a difference between CLOCK_MONOTONIC and CLOCK_BOOTTIME which is the time device was sleeping since boot. It should be reproducible on any device with arm64 and where CLOCK_MONOTONIC and CLOCK_BOOTTIME can give different values. This behavior leads to incorrectly testing expiry for keypairs and consequently failed connections.

Issue seems to be reported here:
https://www.reddit.com/r/chromeos/comments/r2t1x4/chromeos_update_breaks_wireguard_android_vpn_apps/

This change was missing in the original patch causing issues with
GoLang time functions on chromebooks after device wakes up from sleep
and leading to failed connections.

Signed-off-by: Mateusz Markowicz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant