Lmn resampling #273
Draft
Lmn resampling #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still need to implemente resampling in NF instead of just python
Prior, Digitizer took all untagged traces. These two should be equivalent in the context of simulation. In the, until now nonexistent, case of reading a voltage frame from a FrameFileSink-produced file, the '*' bets (mis)interpreted to be a trace tag instead of being a wild card and this caused Digitizer to not get any traces. The entire situation with frame and trace tags is a big jumbled and deserves to be straightened out globally. But, for now, this makes things work and really tags have no place in simulation so should be correct going foward.
- Add artifact mitigation to Resampler via different time-domain padding strategies. - Add a CLI Jsonnet to run just the Resampler. - Move from a BATS test to a Snakemake file to run everything as it is starting to get complex.
|
This replaces the slightly incorrect decimate-then-convolve with proper filtered downsample and linear convolve for FRxER. There is still a very slight unexplained difference between 512ns with 64ns resampled FR, 500ns with 100ns native FR and 512ns to 500ns resample. |
|
I have one more confusion pop up in my mind w.r.t. the fact that ER is peak-normalized. I make this draft again until I can clarify and maybe make some changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for: