-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duplicate mining #139
Comments
Seems like #140 is similar to your issue. Something to do with the recent drops being set years ago. |
@RainOne @notNSANE @gibbed @MCGitHub15 @scryptio I have a bit of time during the weekend, so I will look at it tmrw. A GQL query log, as described in the bug request form ( |
I'am not 100% Sure what i can show without Risk and what not so i "Censored" some stuff myself. Of what i understand and see, the Websocker trys many many times in 1 second to connect somewhere but failed and can't get a Update Drop amount the current Drops that you Have.
|
One of the bugged drops (everything looks normal here): {
"id": "cf5a9c38-2cd9-11ef-9841-0a58a9feac02",
"requiredSubs": 0,
"benefitEdges": [
{
"benefit": {
"id": "9620a89d-b07c-4160-a851-ae832fa6985e_CUSTOM_ID_1834208",
"createdAt": "2024-06-17T18:46:51.501Z",
"entitlementLimit": 1,
"game": {
"id": "515025",
"name": "Overwatch 2",
"__typename": "Game"
},
"imageAssetURL": "https://static-cdn.jtvnw.net/twitch-quests-assets/REWARD/863fe76c-33e0-45af-9e54-9b52f7f226e2.png",
"isIosAvailable": false,
"name": "Rose Gold Mercy Icon",
"ownerOrganization": {
"id": "9620a89d-b07c-4160-a851-ae832fa6985e",
"name": "Blizzard",
"__typename": "Organization"
},
"__typename": "DropBenefit"
},
"entitlementLimit": 1,
"__typename": "DropBenefitEdge"
}
],
"endAt": "2024-06-30T06:58:59.999Z",
"name": "1",
"preconditionDrops": null,
"requiredMinutesWatched": 180,
"startAt": "2024-06-25T18:00:00Z",
"__typename": "TimeBasedDrop"
}, My state for this drop: {
"game": null,
"id": "9620a89d-b07c-4160-a851-ae832fa6985e_CUSTOM_ID_1834208",
"imageURL": "https://static-cdn.jtvnw.net/twitch-quests-assets/REWARD/863fe76c-33e0-45af-9e54-9b52f7f226e2.png",
"isConnected": true,
"lastAwardedAt": "0001-01-01T00:00:00Z",
"name": "Rose Gold Mercy Icon",
"requiredAccountLink": "https://account.battle.net/connections",
"totalCount": 1,
"__typename": "UserDropReward"
},
I have 48 |
Having the exact same issue aswell. Tried reconnecting accounts. Its on Twitchs end. I've also lost multiple drops in my Twitchs inventory, even though i received them prior (and the Miner is showing 0% on them). Something broke on Twitchs end 2 days ago. |
Yup, I'm getting the same results as gibbed - LastAwardedAt is messed up on my API call for campaign progress:
It keeps happening with every game that I already got the drop but it's returning a messed up "LastAwardedAt". Adding it to the ignore list obviously works and moves on to a new game that I didn't get the drops for - rinse and repeat. Edit: Screw it, here's the 2mb log from app opening to when it starts farming for the "Parrot Wings" item (or maybe it was the "Bedazzled Blazer", both are from Project Winter). I already have both items (and they both show the "lastAwardedAt" messed up date. |
I can probably assume old ones are claimed, but for me an overwatch campaign one is from 9 days ago while it started 4 days ago. |
I just removed the requirement for What this means, is that any drop, that was supposedly awarded before it started now counts as claimed. THIS COULD LEAD TO DROPS BEING MISSED!!!I don't know enough about what that date is supposed to mean and why it is checked, so please keep an eye out for that and let me know. |
I think if |
@gibbed > I think if You might be right, but from what I understand, the inventory request, which is where Do you know some drops that can be repeated, that I could test with? |
None that are currently active I think, I've seen repeat drops happen for Warframe but they haven't done that in awhile. |
Actually, I had a thought, and it was correct: Here's a drop from NARAKA: {
"id": "f3635c73-2c78-11ef-964b-0a58a9feac02",
"requiredSubs": 0,
"benefitEdges": [
{
"benefit": {
"id": "417c83f8-80bc-400e-9cde-0c3289ee0a47_CUSTOM_ID_9132752",
"createdAt": "2024-04-03T09:42:37.305Z",
"entitlementLimit": 1,
"game": {
"id": "515474",
"name": "NARAKA: BLADEPOINT",
"__typename": "Game"
},
"imageAssetURL": "https://static-cdn.jtvnw.net/twitch-quests-assets/REWARD/55e319d0-c8fa-43d8-ac99-0b63cac37aed.png",
"isIosAvailable": false,
"name": "Twitch Drops",
"ownerOrganization": {
"id": "417c83f8-80bc-400e-9cde-0c3289ee0a47",
"name": "NetEase",
"__typename": "Organization"
},
"__typename": "DropBenefit"
},
"entitlementLimit": 1,
"__typename": "DropBenefitEdge"
}
],
"endAt": "2024-07-01T18:59:59.999Z",
"name": "1",
"preconditionDrops": null,
"requiredMinutesWatched": 240,
"startAt": "2024-06-24T19:00:00Z",
"__typename": "TimeBasedDrop"
} {
"game": null,
"id": "417c83f8-80bc-400e-9cde-0c3289ee0a47_CUSTOM_ID_9132752",
"imageURL": "https://static-cdn.jtvnw.net/twitch-quests-assets/REWARD/55e319d0-c8fa-43d8-ac99-0b63cac37aed.png",
"isConnected": true,
"lastAwardedAt": "2024-06-25T01:15:07Z",
"name": "Twitch Drops",
"requiredAccountLink": "https://www.narakathegame.com/news/guide/20230710/35647_1097721.html",
"totalCount": 8,
"__typename": "UserDropReward"
}, My assumption then is drops are tracked by that initial ID and not the entitlement list (ie, |
@gibbed I don't want to add a new way of handling stuff and just hope it works, before I have a way of testing it. What you sent shows that It is just a part of Twitch Drops I am not at all familiar with, so I can't include it before I find some current drops, ideally repeating more often, that I can use to figure out how that works. Again, outside of repeating drops, the time check does nothing. The point of it is to somehow avoid marking repeating drops as completed. The above-mentioned commit implementing this is really old (basically from the first couple months of TDM) and I could not find a corresponding issue in the original repo I could use to learn more. I am also afraid, that the current "fix" blocks repeating drops. I just need a campaign to test on and even then I'm not sure I'll have the time for like 3 more weeks. (#127) |
Example from my side (Palia). I've already claimed all drops. Miner continues to farm them:
All of said drops are not shown in my Twitch inventory anymore since 2 days. I received them prior to this bug. Drops having
will get refarmed for obvious reasons. |
Repeating drops on a single stream or any time? |
I have no idea how these work. |
@uniquoo there is an in-dev release, that should have this fixed, but might cause drops that can be claimed multiple times to not be mined again. |
You said you dont really want to alter the code in regards of how it functions right? Would you want me to open a pull requests regardless so i can patch the function and change the check besides just removing |
@uniquoo Yeah. I don't have much time, but I can review the pull request. Since my quick patch probably breaks repeat drops anyway, I'll be happy to merge anything that works for normal drops and see if people find issues. edit: Make sure to create the pull request to in-dev. |
well, Smite repeats the same 7 or 8 drops every week. Marbles on Stream too. If it's on the same stream, it barely happens. Perhaps Warframe, or Hearthstone, but these are very very rare. |
Shakes&Fidget repeat the same Drops all the Time, and Halo Infinite always offers the same Items, allthough in different Variables. I removed that Game from my Prio List after having every one of their drops atleast 10 times now, they usually are almost every Night. |
Not 100% sure if this have something to do with this report too, but i just got this error (latest test build)
|
So, as expected, the fix, while it now doesn't mine already claimed drops, causes issues with repeat drops. I'll see if I can make a specific exception to consider drops done on the 1 date it falsely marks them as complete, while leaving the rest open. More context in #142. @uniquoo If you find a cleaner way, feel free to make a pull request, but it will have to be mergable to whatever in-dev is going to be at that time. |
This comment was marked as outdated.
This comment was marked as outdated.
@zelda0079 try a04dab7, in-dev edit: I think this will still falsely mark them as done if both bugged AND repeating. The fix to that is more complex than what I have time for rn. |
Something that could be considered is the Maybe have it poll this infrequently and if the status isn't close to what the miner thinks should be happening, ignore that drop for an amount of time. [{"operationName":"DropCurrentSessionContext","variables":{"channelLogin":"**CENSORED**","channelID":"**CENSORED**"},"extensions":{"persistedQuery":{"version":1,"sha256Hash":"**CENSORED**"}}}] [
{
"data": {
"currentUser": {
"id": "**CENSORED**",
"dropCurrentSession": {
"channel": {
"id": "501002856",
"name": "the_unknown_marbler",
"displayName": "The_Unknown_Marbler",
"__typename": "Channel"
},
"game": {
"id": "509511",
"displayName": "Marbles on Stream",
"__typename": "Game"
},
"currentMinutesWatched": 3,
"requiredMinutesWatched": 240,
"dropID": "23110bd9-37c4-11ef-9f1a-0a58a9feac02",
"__typename": "DropCurrentSession"
},
"__typename": "User"
}
},
"extensions": {
"durationMilliseconds": 66,
"operationName": "DropCurrentSessionContext",
"requestID": "**CENSORED**"
}
}
] |
Nice, it is working, thank you! |
What is the version you are using? |
I am using version a04dab7, Xdefiant is fine for me, but HellCard is not find.
|
I have same result on Albion Online twitch drop, but after clicking reload, the miner continue. |
The current fix is in v15.7.1 |
This comment was marked as resolved.
This comment was marked as resolved.
@Nixeld I need Given it's 2 months ago, are you sure it's not another iteration of the drop? |
@Windows200000 Actually yeah it looks the one I shown in the previous screenshot is from a previous campaign. I seem to be missing just that 1 item for this iteration of the drop, tried watching a stream on browser and it does not show that I am progressing the drop for it at all. Here is the log of the drop, though this seems to be a different problem now? {
'id': 'cd37cb0b-22ef-11ef-b240-0a58a9feac02',
'benefitEdges': [{
'benefit': {
'id': '227caadf-5d2e-11ee-ae95-0a58a9feac02',
'createdAt': '2023-09-27T12:05:22.353Z',
'entitlementLimit': 1,
'game': {
'id': '213930085',
'name': 'Honkai: Star Rail',
'__typename': 'Game'
},
'imageAssetURL':
'https://static-cdn.jtvnw.net/twitch-quests-assets/REWARD/f5cb5327-04fc-4537-ad6a-142b9bfa89fe.png',
'isIosAvailable': True,
'name': 'Condensed Aether*5',
'ownerOrganization': {
'id': '4523e84a-450a-4ef5-8c6a-5f78706d1f0d',
'name': 'Cognosphere',
'__typename': 'Organization'
},
'__typename': 'DropBenefit'
},
'entitlementLimit': 1,
'__typename': 'DropBenefitEdge'
}],
'endAt': '2024-07-17T02:59:59.999Z',
'name': 'Condensed Aether*5',
'preconditionDrops': None,
'requiredMinutesWatched': 45,
'startAt': '2024-06-19T03:00:00Z',
'__typename': 'TimeBasedDrop'
} |
If you can't progress by manually watching (only 1 stream per account counts, so the Miner and other extensions etc. have to be off), yes. |
@Windows200000 well i guess the question now would be is there a way to detect and ignore these broken drops? Since it prevents me from mining other drops until the bugged one expires or if i remove it from priority list. |
@Nixeld That's already what's being done, but it didn't fix repeating drops, because the time last claimed is what was being used to detect that they're repeating. |
Description
Not sure but I would guess the miner is either not reading the inventory correctly or twitch reporting wrong things again. Since yesterday (guessed) the miner tries to mine already completed drops (i.e. overwatch, lost ark, ... in my case). It looks like it happens for all drops on me and I have to move items in the list so something which can be mined is being mined.
To Reproduce
Expected behavior
Recognizes claimed / open drops properly
Observed behavior
Duplicate mining
Screenshots
No response
Logs
No response
OS
Windows 10
Build
source
Version/Commit
84f4882
Additional context
No response
The text was updated successfully, but these errors were encountered: