-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix undefined reference to mingw #10
Conversation
eukarpov
commented
Nov 27, 2023
•
edited
Loading
edited
* testing aarch64 condition in CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this comment clearly says that the __strtold
/ __strtod
/ __strtof
implementations are relavant to 10 byte long double
s and since aarch64-w64-mingw32
is using 16byte `long double`s (at least for now), I am willing to accept any change that efectively sets:
#define gfc_strtof strtof
#define gfc_strtod strtod
#define gfc_strtold strtold
and that hides / do not use __strtold
/ __strtod
/ __strtof
.
Is the current state of the PR final in that sense?
strtof and strtod should not be impacted as they use float and double
I would prefer to keep changes under mingw condition as they are related to it. wdyt? |
That's true, sorry for the confusion. I am fine with any change that hides (stops using) |