Skip to content

Remove object lifetime cast #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OLEGSHA merged 1 commit into from
May 11, 2025
Merged

Remove object lifetime cast #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/crash.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,13 @@ mod context {

if let Some(entries) = &mut context.entries {
let x: &mut Self = self.get_unchecked_mut();
entries.push(x as *mut Self as *mut dyn EntryLike);
// SAFETY: We extend the lifetime of `Self` to `'static`, I don't know
// if this is sound.
let x = std::mem::transmute::<
*mut (dyn EntryLike + '_),
*mut (dyn EntryLike + 'static),
>(x);
entries.push(x);
} else {
// Fail silently: crash context has been forever disabled for this thread
}
Expand Down