Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove proprietary Intel IPP and Microsoft DirectX SDK files to avoid copyright violation #1378

Open
wants to merge 2 commits into
base: community
Choose a base branch
from
Open

Remove proprietary Intel IPP and Microsoft DirectX SDK files to avoid copyright violation #1378

wants to merge 2 commits into from
+0 −0

Conversation

GomezMig03
Copy link

No description provided.

overanalytcl
overanalytcl reviewed Sep 27, 2024
View reviewed changes
Copy link

@overanalytcl overanalytcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rollerozxa
Copy link

The Intel IPP libraries were also extracted into Src/external_dependencies/ repository for some reason in addition to being distributed in an archive leading to the repository being like 2 gigabytes in size

@ghost ghost mentioned this pull request Sep 27, 2024
Closed
@Poikilos
Copy link

O boy, probably going to need lots of git-filter-repo commands after all this is settled (not to mention stuff already deleted but still in git history, like Qt):

Theoldnation
Theoldnation reviewed Sep 27, 2024
View reviewed changes
Copy link

@Theoldnation Theoldnation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i do suggest to approve this as will be getting claims from microsoft and anybody's else's around for using propietary code from them

Lonso33
Lonso33 reviewed Sep 27, 2024
View reviewed changes
Copy link

@Lonso33 Lonso33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ghost

This comment was marked as resolved.

Sign in to view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Theoldnation Theoldnation Theoldnation left review comments

@overanalytcl overanalytcl overanalytcl left review comments

@Lonso33 Lonso33 Lonso33 left review comments

At least 5 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@GomezMig03 @rollerozxa @Poikilos @Theoldnation @overanalytcl @Lonso33