Encode client and domain in oem/unicode in Client#authenticate!
#19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using my SMB2 implementation to exercise this code. Type1 messages have to have the domain/workstation encoded as OEM (ascii), so we need to pass them in as either
"binary"
or"utf-8"
encoding to theClient
constructor. However, when we build the Type3 message, it has to be in whatever encoding was negotiated, usually Unicode ("utf-16le").Without this change, passing correct user/pass:
STATUS_LOGON_FAILURE
After this change, passing domain as ascii-8bit or utf-8 works as expected.