Various improvements #38
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diggsey
force-pushed
the
db-platformed-improvements
branch
8 times, most recently
from
6b41fb5 to
57cdf10
Compare
- Add user authentication method - Statically (but lazily) initialize regexes - Use an error type rather than strings - Return structured data from auth methods
Diggsey
force-pushed
the
db-platformed-improvements
branch
from
57cdf10 to
77b0dfa
Compare
|
@WillSewell Can we get this merged and deployed? |
|
👋 thanks for contributing to this repository. I'm afraid due to life circumstances I just haven't had the bandwidth to review PRs, and stay up to date with Rust in general. For that reason I'm afraid I'm going to have to archive this repository without merging outstanding PRs (at least for the time being). Apologies I didn't get this notice in sooner. |
Pusher returns an error (but otherwise works) when you try and authenticate the client with a null watchlist. An empty list serves the same purpose, so remove the optionality from this structure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rustlsfeature and associated builder methodsA caveat is that I haven't tested the user authentication yet, but should be able to do that soon.