Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Previous makes the carousel jump #17

Closed
JohnMica opened this issue Mar 4, 2018 · 6 comments
Closed

Previous makes the carousel jump #17

JohnMica opened this issue Mar 4, 2018 · 6 comments

Comments

@JohnMica
Copy link

JohnMica commented Mar 4, 2018

as in the codepen https://codepen.io/JohnMica/pen/WMBeyj?editors=1010

active image is image 3
press previous
carousel jumps to image 1 and slides to image 2

not sure why this is (i was expecting a 'reverse' in the slide animation)

@andrevandal
Copy link

This is really happen.
I think that reverse animation wasn't implemented.

@JohnMica
Copy link
Author

JohnMica commented Mar 5, 2018 via email

@Wikiki
Copy link
Owner

Wikiki commented Mar 5, 2018

Hi,

actually you're right the fade item is the only one working with Hero currently due to this issue I did not succeed to fix.

I'll try again....

@Wikiki
Copy link
Owner

Wikiki commented Mar 5, 2018

But...I just see it's happening on classic carousel too :-(

@Wikiki
Copy link
Owner

Wikiki commented Mar 5, 2018

I fixed it.
I will update the repo soon

Wikiki added a commit that referenced this issue Mar 5, 2018
@Wikiki
Copy link
Owner

Wikiki commented Mar 5, 2018

Done. see commit #1355319

@Wikiki Wikiki closed this as completed Mar 5, 2018
Wikiki added a commit that referenced this issue Mar 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants