Unobserve intersection observer

Wikia · Feb 9, 2018 · 8d29e42 · 8d29e42
1 parent 8306c39
commit 8d29e42
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/addon/mixins/in-viewport.js b/addon/mixins/in-viewport.js
@@ -55,9 +55,6 @@ export default Mixin.create({
   willDestroyElement() {
     this._super(...arguments);
     this._unbindListeners();
-    if (this.intersectionObserver) {
-      this.intersectionObserver.unobserve(this.element);
-    }
   },
 
   _buildOptions(defaultOptions = {}) {
@@ -257,6 +254,13 @@ export default Mixin.create({
       $(context).off(`${event}.${elementId}`);
     });
 
+    this._unobserveIntersectionObserver();
     this._unbindScrollDirectionListener();
   }
+
+  _unobserveIntersectionObserver() {
+    if (this.intersectionObserver) {
+      this.intersectionObserver.unobserve(this.element);
+    }
+  }
 });