Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add types for remaining app modules #295

Closed
2 of 19 tasks
hirako2000 opened this issue Jul 14, 2017 · 1 comment
Closed
2 of 19 tasks

Add types for remaining app modules #295

hirako2000 opened this issue Jul 14, 2017 · 1 comment
Milestone
v2.1.6

Comments

@hirako2000
Copy link
Collaborator

Other app modules need types added.

Version:
  • v2.x.x
  • v1.x.x
Issue type:
  • Bug
  • Proposal/Enhancement
  • Question
  • Discussion
Tested on:
Desktop
  • Chrome
  • Chrome Canary
  • Chrome dev-channel
  • Firefox
  • Opera
  • Microsoft IE
  • Microsoft Edge
Android
  • Chrome
  • Firefox
  • Opera
IOS
  • Chrome
  • Firefox
  • Opera
hirako2000 added a commit that referenced this issue Jul 14, 2017
@hirako2000
Adds types for ResizeModule #295
38b5d51
hirako2000 added a commit that referenced this issue Jul 14, 2017
@hirako2000
Adds types for SceneModule #295
3ee4c93
hirako2000 added a commit that referenced this issue Jul 14, 2017
@hirako2000
Adds types for StateModule - also fixes typo and incorrectness in src…
feae8d1 
… doc #295
hirako2000 added a commit that referenced this issue Jul 14, 2017
@hirako2000
Adds types for VirtualMouseModule - #295
c05b20e
hirako2000 added a commit that referenced this issue Jul 15, 2017
@hirako2000
Fixes incorrect types for TextureModule and DynamicGeometryModule #295
77373e6
hirako2000 added a commit that referenced this issue Jul 15, 2017
@hirako2000
Adds some basic type tests for Animation and DynamicGeometry modules #…
c631021 
…295
hirako2000 added a commit that referenced this issue Jul 16, 2017
@hirako2000
Merge pull request #296 from WhitestormJS/#295
a2c761a 
PR for #295
@hirako2000
Copy link
Collaborator Author

Some of the modules need to be completed, left TODOs. at least we have all classes so that typescript project can have most types for those.

@sasha240100 sasha240100 added this to the v2.1.6 milestone Jul 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.1.6
Development

No branches or pull requests
2 participants
@hirako2000 @sasha240100