-
-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide typings #189
Comments
@hirako2000 how to implement? |
Creating typings, definitelytyped |
I can help with this; It would be very nice to have with any project I would use WHS in. |
@ElectrcNINJA would be awesome cause I am 0 at typescript. Make a fork/branch with a name "#189", work there and do a PR |
typescript over flow is a good call I think |
How well does TS handle static properties on a class? Can it autosuggest a class's static properties in IDEs? Could maybe annotate components with how they expose bridges with something like static bridgeTypes = [ ' geometry', 'material', 'mesh', 'onWrap' ] |
from my little experience with TS, types are perfectly supported, so long as the typings are well defined (and installed) for dep libraries written in JS of course. Best is to see int action and appreciate how good it can be to have types available, especially when learning how to use unfamiliar APIs. If you setup a skeleton typescript project, import a poplar library such as lodash. insteall definitlytyped and lodash's typings. |
@sasha240100 Waiting for typings. 😄 Have you seen that you can use |
Zored, we do need typings, we've been busy doing other things in the mean time, and would love someone having typings definitions experience or knowledge to take the lead on this. Are you able to give us a hand with this? |
@hirako2000 ok, I'll write definitions and I'll create pull-request in several days. Currently I try to adapt |
I'v started adding type definitions, starting with Core. |
@hirako2000 Please don't contribute to DT. Instead add the types directly to this project's repo (as @zored said). This is the recommended way of providing typings for js projects. See vuejs for reference: This way:
|
thanks a lot for the input @d-ph, will do that |
A few types are added and this Issue became a snowball as it included jsDoc setup etc. |
Typescript developers would benefit in having typings for whs. There are already some typings for
three.js
.See best practice to write type definitions.
Version:
Issue type:
Tested on:
Desktop
Android
IOS
The text was updated successfully, but these errors were encountered: