Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/negative rating #227

Merged
merged 9 commits into from
Jul 24, 2022
Merged

Fix/negative rating #227

merged 9 commits into from
Jul 24, 2022

Conversation

Segelzwerg
Copy link
Contributor

No description provided.

@Segelzwerg Segelzwerg linked an issue Jul 23, 2022 that may be closed by this pull request
BUG: player rating should not be negative #204
Closed
@Segelzwerg Segelzwerg added the bug Something isn't working label Jul 23, 2022
@Segelzwerg
Copy link
Contributor Author

Probably a bug in actions Whist-Team/actions#4

@codecov
Copy link

codecov bot commented Jul 23, 2022 •
edited
Loading

Codecov Report

Merging #227 (02d035f) into main (10b9661) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #227      +/-   ##
==========================================
+ Coverage   97.21%   97.24%   +0.02%     
==========================================
  Files          28       29       +1     
  Lines         754      762       +8     
==========================================
+ Hits          733      741       +8     
  Misses         21       21
Impacted Files Coverage Δ
whist_core/error/player_error.py 100.00% <100.00%> (ø)
whist_core/user/player.py 96.00% <100.00%> (+1.55%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@Segelzwerg Segelzwerg marked this pull request as ready for review July 24, 2022 07:43
@Segelzwerg
Copy link
Contributor Author

Probably a bug in actions Whist-Team/actions#4

Or user error 😉

iTitus
iTitus requested changes Jul 24, 2022
View reviewed changes
@Segelzwerg Segelzwerg requested a review from iTitus July 24, 2022 16:17
@iTitus iTitus merged commit 6f41a23 into main Jul 24, 2022
@iTitus iTitus deleted the fix/negative-rating branch July 24, 2022 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iTitus iTitus iTitus approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: player rating should not be negative
2 participants
@Segelzwerg @iTitus