Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPDATE: extract score calculator #225

Merged
merged 15 commits into from
Jul 23, 2022
Merged

UPDATE: extract score calculator #225

merged 15 commits into from
Jul 23, 2022

Conversation

Segelzwerg
Copy link
Contributor

No description provided.

@Segelzwerg
REFACTOR: move calculation to util class
8a6f0e3 
Signed-off-by: Segelzwerg <[email protected]>
@Segelzwerg
ADD: result type hint
123495b 
Signed-off-by: Segelzwerg <[email protected]>
@Segelzwerg
ADD: parameter type hitns
9e7505c 
Signed-off-by: Segelzwerg <[email protected]>
@Segelzwerg
ADD: documentation
b244ab2 
REFACTOR: parameter names and constant

Signed-off-by: Segelzwerg <[email protected]>
@Segelzwerg
ADD: calculator test
7cad80a 
Signed-off-by: Segelzwerg <[email protected]>
@Segelzwerg Segelzwerg self-assigned this Jul 22, 2022
@Segelzwerg Segelzwerg added the enhancement New feature or request label Jul 22, 2022
@codecov
Copy link

codecov bot commented Jul 22, 2022 •
edited
Loading

Codecov Report

Merging #225 (603d084) into main (3694684) will increase coverage by 1.52%.
The diff coverage is 96.29%.

@@            Coverage Diff             @@
##             main     #225      +/-   ##
==========================================
+ Coverage   95.68%   97.21%   +1.52%     
==========================================
  Files          27       28       +1     
  Lines         742      754      +12     
==========================================
+ Hits          710      733      +23     
+ Misses         32       21      -11
Impacted Files Coverage Δ
whist_core/game/game.py 84.84% <50.00%> (+19.63%) ⬆️
whist_core/game/play_order.py 100.00% <100.00%> (ø)
whist_core/scoring/score_calculator.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

@Segelzwerg
ADD: documentation
e7ba954 
UPDATE: rename method

Signed-off-by: Segelzwerg <[email protected]>
@Segelzwerg
ADD: documentation
30a60f1 
Signed-off-by: Segelzwerg <[email protected]>
@Segelzwerg Segelzwerg requested a review from iTitus July 22, 2022 21:05
@Segelzwerg Segelzwerg marked this pull request as ready for review July 22, 2022 21:05
@Segelzwerg Segelzwerg linked an issue Jul 22, 2022 that may be closed by this pull request
FEATURE: Score Calculator #211
Closed
@iTitus iTitus merged commit 10b9661 into main Jul 23, 2022
@iTitus iTitus deleted the feature/score_calculator branch July 23, 2022 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iTitus iTitus iTitus approved these changes

Assignees

@Segelzwerg Segelzwerg

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FEATURE: Score Calculator
2 participants
@Segelzwerg @iTitus