Chore: Bump Fluent Validation to 12.1.1#93
Merged
Conversation
This is a large number of files, but a consistent implementation of edit style. The core of the change is that Fluent 12 now requires strongly-typed arguments when constructing, so, because we use it in a lot of places, it's a lot of small edits.
plz12345
force-pushed
the
bump-validation-package
branch
from
00644ca to
2907672
Compare
sampulsar
approved these changes
Feb 11, 2026
plz12345
added a commit
to plz12345/Whisparr-Eros
that referenced
this pull request
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a large number of files, but a consistent implementation of edit style. The core of the change is that Fluent 12 now requires strongly-typed arguments when constructing, so, because we use it in a lot of places, it's a lot of small edits.
This pass DOES NOT statically set the explicit object types (e.g., using T instead of Movie for movie validation). That would've been a much more intense edit, while not gaining much beyond build-time type safety. We can revisit that in the future, but for now, this is just as type-safe as what we previously had, but, with the newer package improvements.
You'll notice creating rules for simple things like "is not null" is way more simple in the new package.
This builds and runs clean, tests clean, and I ran through a few things in Settings that I knew would throw validation errors, all successful.
Database Migration
NO
Screenshot (if UI related)
Todos
Issues Fixed or Closed by this PR