Skip to content

Chore: Cloudflare cookie test expiring and reddening CI #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
plz12345 merged 1 commit into from
Jul 15, 2026
Merged

Chore: Cloudflare cookie test expiring and reddening CI #325

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/NzbDrone.Common.Test/Http/HttpClientFixture.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -796,8 +796,13 @@ public async Task should_parse_malformed_cloudflare_cookie(string culture)
Thread.CurrentThread.CurrentUICulture = CultureInfo.GetCultureInfo(culture);
try
{
// the date is bad in the below - should be 13-Jul-2026
var malformedCookie = @"__cfduid=d29e686a9d65800021c66faca0a29b4261436890790; expires=Mon, 13-Jul-26 16:19:50 GMT; path=/; HttpOnly";
// The two digit year is the malformed part: a server should send 2027, not 27. Generate the date
// rather than hardcoding it, otherwise the cookie eventually expires and the test starts failing
// on a fixed date for everyone. Format as invariant because that is what a server sends; the
// thread culture stays set to the test case's culture so we still cover parsing it as a client
// running under a non-English locale.
var expires = DateTime.UtcNow.AddYears(1).ToString("ddd, dd-MMM-yy HH:mm:ss 'GMT'", CultureInfo.InvariantCulture);
var malformedCookie = $"__cfduid=d29e686a9d65800021c66faca0a29b4261436890790; expires={expires}; path=/; HttpOnly";
var requestSet = new HttpRequestBuilder($"https://{_httpBinHost}/response-headers")
.AddQueryParam("Set-Cookie", malformedCookie)
.Build();
Expand Down
Loading