chore: migrate "add new studio" lookup and add flow to tanstack query - #301
Merged
plz12345 merged 4 commits intoJun 19, 2026
Merged
Conversation
Contributor
|
Not sure if you're aware, this is both still in draft, and now has a merge conflict locking it. |
Contributor
Author
yes, i am aware |
Mothball7205
force-pushed
the
modernize-studio-lookup
branch
from
June 18, 2026 18:15
951074b to
7e9a7fa
Compare
Mothball7205
force-pushed
the
modernize-studio-lookup
branch
from
June 18, 2026 19:41
7e9a7fa to
fd6848f
Compare
|
Mothball7205
marked this pull request as ready for review
June 18, 2026 19:54
plz12345
changed the title
plz12345
approved these changes
Jun 19, 2026
plz12345
left a comment
plz12345
left a comment
Contributor
There was a problem hiding this comment.
Looks to be copying the pattern we use on movies and scenes, so no major concerns. Thanks for splitting into smaller PR chunks. We can let this ride on eros-develop for a couple of weeks before looking to do a merge on the performer flavor of this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Database Migration
NO
Description
smaller part of #300
moves the studio lookup/add flow off redux and onto tanstack query, matching the pattern already used for movies. the isExisting flag now comes directly from the backend lookup endpoint instead of requiring a separate round-trip