Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add waveforms to voice messages #180

Merged
merged 29 commits into from
Jul 14, 2023
Merged

feat: Add waveforms to voice messages #180

merged 29 commits into from
Jul 14, 2023

Conversation

codebossdev
Copy link
Contributor

No description provided.

@whiskeysockets-bot
Copy link
Contributor

Thanks for your contribution.

The next step is to wait for review and approval to merge it to main repository

The community can help reacting with a thumb up (:thumbsup:) for approval and rocket (:rocket:) for who has tested it.

To test this PR you can run the following command below:

# NPM
npm install @whiskeysockets/baileys@WhiskeySockets/Baileys#audio-waveforms
# YARN v2
yarn add @whiskeysockets/baileys@WhiskeySockets/Baileys#audio-waveforms

@codebossdev codebossdev changed the title Waveform initial implementation feat: Add waveforms to voice messages Jun 24, 2023
@codebossdev codebossdev enabled auto-merge (squash) June 24, 2023 00:23
@codebossdev codebossdev enabled auto-merge (squash) June 24, 2023 00:23
@codebossdev codebossdev enabled auto-merge (squash) June 24, 2023 00:35
src/Utils/messages-media.ts Outdated Show resolved Hide resolved
@edgardmessias edgardmessias enabled auto-merge (squash) June 26, 2023 11:22
@vphelipe
Copy link

It didn't work here, an error occurs when trying to create the waveforms

@zennn08
Copy link
Contributor

zennn08 commented Jul 2, 2023

I get this error

Failed to generate waveform: TypeError: Cannot read properties of undefined (reading 'getChannelData')

TypeError: successCallback is not a function

@codebossdev codebossdev disabled auto-merge July 8, 2023 02:00
@codebossdev codebossdev enabled auto-merge (squash) July 8, 2023 02:00
@Auties00
Copy link
Collaborator

Auties00 commented Jul 10, 2023

lgtm, could be squash the commits though?

also needs to be tested

@edgardmessias
Copy link
Contributor

Yes, I think the squash is the best way using convetional commit name to generate the changelog.

lgtm, could be squash the commits though?

also needs to be tested

@edgardmessias edgardmessias merged commit 2c76713 into master Jul 14, 2023
2 checks passed
@edgardmessias edgardmessias deleted the audio-waveforms branch July 14, 2023 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants