Skip to content

[Refactor/#440] 워크스페이스 삭제 모달 컴포넌트로 분리 - #442

Merged
jjjsun merged 10 commits into
developfrom
refactor/#440
Aug 10, 2026
Merged

[Refactor/#440] 워크스페이스 삭제 모달 컴포넌트로 분리#442
jjjsun merged 10 commits into
developfrom
refactor/#440

Conversation

@jjjsun

@jjjsun jjjsun commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

🚨 관련 이슈

Closed #440

✨ 변경사항

  • 🐞 BugFix Something isn't working
  • 💻 CrossBrowsing Browser compatibility
  • 🌏 Deploy Deploy
  • 🎨 Design Markup & styling
  • 📃 Docs Documentation writing and editing (README.md, etc.)
  • ✨ Feature Feature
  • 🔨 Refactor Code refactoring
  • ⚙️ Setting Development environment setup
  • ✅ Test Test related (storybook, jest, etc.)

✏️ 작업 내용

  • DeleteWorkspaceModal 컴포넌트 추가
  • WorkspaceSetting 인라인 삭제 모달 제거 후 교체 진행
  • 아이콘, title, 본문 순으로 세로 스택으로 변경하여 조직 양도 모달과 패턴 동일하게 수정

😅 미완성 작업

N/A

📢 논의 사항 및 참고 사항

기능 변경은 없습니다. UI만 분리하여 작업하였습니다.

💬 리뷰어 가이드 (P-Rules)
P1: 필수 반영 (Critical) - 버그 가능성, 컨벤션 위반. 해결 전 머지 불가.
P2: 적극 권장 (Recommended) - 더 나은 대안 제시. 가급적 반영 권장.
P3: 제안 (Suggestion) - 아이디어 공유. 반영 여부는 드라이버 자율.
P4: 단순 확인/칭찬 (Nit) - 사소한 오타, 칭찬 등 피드백.

@jjjsun
jjjsun requested review from Seojegyeong and YermIm August 10, 2026 07:36
@jjjsun jjjsun self-assigned this Aug 10, 2026
@jjjsun jjjsun added 🎨 Html&css 마크업 & 스타일링 🔨 Refactor 코드 리팩토링 labels Aug 10, 2026
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@jjjsun, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 31 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 26a07744-78ed-4ca8-aa34-80b8187faf2f

📥 Commits

Reviewing files that changed from the base of the PR and between b7126dc and 3987dff.

📒 Files selected for processing (16)
  • src/components/common/dropdownmenu/DropdownMenu.tsx
  • src/components/common/modal/Modal.tsx
  • src/components/common/select/SearchSelect.tsx
  • src/components/setting/NotificationSection.tsx
  • src/components/setting/PasswordSection.tsx
  • src/components/setting/ProfileSection.tsx
  • src/components/timeline/TimelineBar.tsx
  • src/components/timeline/TimelinePerformancePanel.tsx
  • src/components/workspace/DeleteWorkspaceModal.tsx
  • src/components/workspace/MemberItem.tsx
  • src/components/workspace/MemberSearchSelect.tsx
  • src/components/workspace/PermissionTable.tsx
  • src/components/workspace/TransferOwnerModal.tsx
  • src/pages/dashboard/timeline/Timeline.tsx
  • src/pages/workspace/Workspace.tsx
  • src/pages/workspace/WorkspaceSetting.tsx

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

📚 Storybook 배포 완료

항목 링크
📖 Storybook https://69a147b60a56365d9e2185ef-gougcdkujw.chromatic.com/
🔍 Chromatic https://www.chromatic.com/build?appId=69a147b60a56365d9e2185ef&number=609

@YermIm YermIm left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P4: 확인했습니다!

@jjjsun
jjjsun merged commit 38f4154 into develop Aug 10, 2026
3 checks passed
@jjjsun
jjjsun deleted the refactor/#440 branch August 10, 2026 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🎨 Html&css 마크업 & 스타일링 🔨 Refactor 코드 리팩토링

Projects

None yet

Development

Successfully merging this pull request may close these issues.

♻️ [Refactor] 워크스페이스 삭제 모달을 조직양도 모달 패턴처럼 분리

2 participants