[Feature/#431] 담당 페이지(워크스페이스/타임라인/알림/설정) 모바일 반응형 및 타임라인 드랍다운 수정 - #441
Conversation
|
Warning Review limit reached
Next review available in: 47 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthrough드롭다운의 상하·좌우 배치 계산을 개선했습니다. 타임라인 메뉴에 배치 옵션을 추가했습니다. 설정과 워크스페이스 화면에 모바일·태블릿 반응형 스타일과 줄바꿈 처리를 적용했습니다. Changes반응형 UI 개선
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant Timeline
participant TimelineBar
participant DropdownMenu
Timeline->>TimelineBar: 마지막 행에 menuPlacement="top" 전달
TimelineBar->>DropdownMenu: menuPlacement 전달
DropdownMenu->>DropdownMenu: 클리핑 경계와 공간 계산
DropdownMenu-->>TimelineBar: 메뉴 위치와 transform origin 적용
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
📚 Storybook 배포 완료
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/components/common/dropdownmenu/DropdownMenu.tsx`:
- Around line 152-175: 분리한 위치 계산 함수를 사용해 열린 메뉴의 배치를 재계산하세요. DropdownMenu의
useLayoutEffect에서 viewport resize와 capture 단계 scroll 이벤트를 구독하고, 관련 요소의 크기 변경은
ResizeObserver로 관찰해 resolvedPlacement와 horizontalAlign을 갱신하세요. 메뉴가 닫혔거나 inFlow인
경우 기존 기본값 처리는 유지하고, effect 정리 시 모든 이벤트 리스너와 observer를 제거하세요.
In `@src/components/setting/NotificationSection.tsx`:
- Line 269: Update the Discord Webhook wrapperClassName to use the Tailwind
utility tablet:w-full instead of tablet:w-fill, while preserving the base w-1/4
and shrink-0 classes.
In `@src/components/timeline/TimelineBar.tsx`:
- Around line 132-140: Update the main content layout in TimelineBar so that
when showActions is enabled it reserves trailing space for the absolute menu
container, such as by applying the existing layout’s equivalent of pr-10. Keep
the spacing conditional and ensure long titles or status text cannot overlap the
DropdownMenu area.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: ea282d64-d670-4f6c-8597-337a6d483865
📒 Files selected for processing (15)
src/components/common/dropdownmenu/DropdownMenu.tsxsrc/components/common/modal/Modal.tsxsrc/components/common/select/SearchSelect.tsxsrc/components/setting/NotificationSection.tsxsrc/components/setting/PasswordSection.tsxsrc/components/setting/ProfileSection.tsxsrc/components/timeline/TimelineBar.tsxsrc/components/timeline/TimelinePerformancePanel.tsxsrc/components/workspace/MemberItem.tsxsrc/components/workspace/MemberSearchSelect.tsxsrc/components/workspace/PermissionTable.tsxsrc/components/workspace/TransferOwnerModal.tsxsrc/pages/dashboard/timeline/Timeline.tsxsrc/pages/workspace/Workspace.tsxsrc/pages/workspace/WorkspaceSetting.tsx
💤 Files with no reviewable changes (1)
- src/components/common/modal/Modal.tsx
2 participants
🚨 관련 이슈
Closed #431
✨ 변경사항
✏️ 작업 내용
타임라인
알림/설정
NotificationSection모바일 스택 레이아웃 적용p-8 tablet:p-6으로 패딩 동일하게 정리워크스페이스
공통
Modal닫기 버튼용 비대칭pr-12제거하였습니다.SearchSelect검색 아이콘을rightElement로 배치하여 placeholder` 겹침을 방지하였습니다.😅 미완성 작업
📢 논의 사항 및 참고 사항
Summary by CodeRabbit