[Refactor/#434] 회원 탈퇴 에러 메세지 매핑 제거 - #435
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough회원 탈퇴 오류 처리에서 오류 코드별 Changes회원 탈퇴 오류 처리
Estimated code review effort: 2 (Simple) | ~5 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
📚 Storybook 배포 완료
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚨 관련 이슈
Closed #434
✨ 변경사항
✏️ 작업 내용
useDeleteMyAccount.ts의WITHDRAW_ERROR_MESSAGE제거IApiErrorResponse.message를 바로 사용하도록 변경😅 미완성 작업
N/A
📢 논의 사항 및 참고 사항
Swagger 에러 메세지가 문장으로 끝나지 않아서 UX용 code 매핑 넣었었는데,
프로젝트 공통 에러 처리 방식이랑 맞지 않아서
apiError.message사용으로 통일했습니다.추후에 필요하면 백엔드 메세지 문구를 다듬는 방향으로 논의 해보면 좋을것같습니다!
Summary by CodeRabbit