[Feature/#416] 플랫폼 대시보드 누락 기능·상태 UX 보완 - #426
Conversation
|
Warning Review limit reached
Next review available in: 23 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough플랫폼 대시보드가 URL 기반 플랫폼 선택, 연결 플랫폼 필터링, 성과 부분 실패 처리를 지원합니다. 개별·전체 트래픽 차트에 PNG·SVG·CSV 다운로드를 추가했습니다. 토큰 만료 판별과 워크스페이스 구분선 표시도 변경했습니다. Changes플랫폼 대시보드 개선
워크스페이스 스위처 표시
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant Operator as 대시보드 사용자
participant Dashboard as PlatformDashboard
participant Switcher as PlatformViewSwitcher
participant URL as URL 검색 파라미터
participant Performance as usePlatformPerformance
participant View as AllPlatformView
Operator->>Switcher: 플랫폼 선택
Switcher->>Dashboard: 선택된 provider 전달
Dashboard->>URL: provider 파라미터 갱신
Dashboard->>Performance: 사용 가능한 플랫폼 성과 조회
Performance-->>View: platforms와 failedProviders 반환
View-->>Operator: 성공 카드와 실패 카드 렌더링
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
📚 Storybook 배포 완료
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
src/components/dashboard/platform/PlatformTrafficChartDownload.tsx (1)
14-17: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value컴포넌트 props 타입 이름을
I*Props로 변경하세요.
TPlatformTrafficChartDownloadProps는 컴포넌트 props 타입 규칙과 다릅니다.수정 예시
-type TPlatformTrafficChartDownloadProps = { +interface IPlatformTrafficChartDownloadProps { /** 개별 보기: 플랫폼 코드 (GOOGLE 등). 없으면 전체보기 */ platform?: string; -}; +} export default function PlatformTrafficChartDownload({ platform, -}: TPlatformTrafficChartDownloadProps) { +}: IPlatformTrafficChartDownloadProps) {As per coding guidelines, component props use
I*Props.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/components/dashboard/platform/PlatformTrafficChartDownload.tsx` around lines 14 - 17, Rename the component props type TPlatformTrafficChartDownloadProps to IPlatformTrafficChartDownloadProps and update all references to use the new I*Props naming convention.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/components/dashboard/platform/PlatformTrafficChartDownload.tsx`:
- Around line 19-50: Hide or disable the download menu in
PlatformTrafficChartDownload when its new available prop is false, while
preserving normal downloads when true. In SinglePlatformView, pass available
based on clickStreamData?.timeSeriesData.length so downloads are only exposed
when chart data exists; update both referenced sites accordingly.
In `@src/pages/dashboard/platform/PlatformDashboard.tsx`:
- Line 49: Update the provider validation logic in PlatformDashboard around
usePlatformConnections so it runs only after connections has been successfully
received, not merely when isFetched is true; guard the providerFromUrl
normalization and related effect against undefined connection data so failed
requests do not replace the deep-link provider with the all-view value or remove
its query parameter.
---
Nitpick comments:
In `@src/components/dashboard/platform/PlatformTrafficChartDownload.tsx`:
- Around line 14-17: Rename the component props type
TPlatformTrafficChartDownloadProps to IPlatformTrafficChartDownloadProps and
update all references to use the new I*Props naming convention.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: cdec443b-e6b4-4784-8048-974a9ed7a342
📒 Files selected for processing (12)
src/components/dashboard/platform/AllPlatformTrafficChart.tsxsrc/components/dashboard/platform/AllPlatformView.tsxsrc/components/dashboard/platform/PlatformTrafficChart.tsxsrc/components/dashboard/platform/PlatformTrafficChartDownload.tsxsrc/components/dashboard/platform/PlatformViewSwitcher.tsxsrc/components/dashboard/platform/SinglePlatformView.tsxsrc/components/dashboard/platform/platformTrafficChartDownload.config.tssrc/components/sidebar/WorkspaceSwitcher.tsxsrc/hooks/dashboard/usePlatformPerformance.tssrc/pages/dashboard/platform/PlatformDashboard.tsxsrc/types/dashboard/platform.tssrc/utils/integration/mapPlatformAccounts.ts
2 participants
🚨 관련 이슈
close #416
✨ 변경사항
✏️ 작업 내용
connected(+ 토큰 유효) 플랫폼만 노출하도록 필터링WorkspaceSwitcher에서 워크스페이스 1개일 때새 워크스페이스위 구분선 숨김?provider=URL과 동기화error)인 provider는 전체보기로 정리하고 query 제거tokenExpireAt은 해당 일자부터 만료로 판정😅 미완성 작업
N/A
📢 논의 사항 및 참고 사항
N/A
Summary by CodeRabbit