[Bugfix/#379] 회원가입 완료 후 로그인 페이지로 이동되지 않는 문제 해결 - #380
Merged
Conversation
📝 WalkthroughWalkthrough회원가입 프로필 설정 완료 시 Changes회원가입 완료 처리
Estimated code review effort: 2 (Simple) | ~5 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
📚 Storybook 배포 완료
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚨 관련 이슈
Closed #379
✨ 변경사항
✏️ 작업 내용
resetAuth()를 먼저 호출하게 되면서, store의 email이 비워지고, 그다음navigate(buildPathWithReturnUrl("/login", returnUrl)단계에서 같은 컴포넌트의 guarduseEffect가!email을 먼저 감지해서/signup으로 다시 이동하는 에러를 수정했습니다.login으로만 이동하고(returnUrl이 있다면 그 Url로 이동),email과socialId초기화는Signup페이지에서resetAuth실행됩니다.😅 미완성 작업
N/A
📢 논의 사항 및 참고 사항
resetAuth()는 폼 전체 지우는 것이 아니라 Zustand의email,socialId`만 초기화합니다. 나머지 입력값은 페이지 언마운트시 함께 사라지는 구조입니다.!email || !password은 그대로 동작 유지됩니다.Summary by CodeRabbit