[Feature/#310] 플랫폼·광고·연동 페이지 ErrorBoundary 적용 - #362
Merged
Conversation
📝 WalkthroughWalkthrough플랫폼 대시보드와 광고·연동 페이지의 주요 차트, 지표, 테이블 렌더링에 Changes플랫폼 대시보드
광고 및 캠페인 화면
플랫폼 연동 화면
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
📚 Storybook 배포 완료
|
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/components/dashboard/platform/AllPlatformView.tsx`:
- Around line 170-173: Update the AllPlatformTrafficChart error flow around
useClickStream so an SSE failure can recover after MAX_RETRIES instead of
remaining in ErrorBoundary fallback; provide a manual retry action that aborts
or resets the failed stream and reconnects it, or add equivalent persistent
reconnection logic, while preserving the existing fallback display.
In `@src/pages/ads/list/AdsListPage.tsx`:
- Around line 222-234: Replace the chart-specific ChartErrorFallback with a
table- or generic-area fallback for CampaignTable in
src/pages/ads/list/AdsListPage.tsx lines 222-234, use an AdListTable- or
generic-area fallback for the ErrorBoundary around AdListTable in
src/pages/ads/list/CampaignDetail.tsx lines 330-342, and use a
campaign-linking-selection or generic-area fallback for the boundary in
src/pages/ads/new/CampaignGroup.tsx lines 98-145. Keep each existing
ErrorBoundary scope and reset behavior unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 47389ceb-1c71-4d4e-b138-a64edf204f9a
📒 Files selected for processing (6)
src/components/dashboard/platform/AllPlatformView.tsxsrc/components/dashboard/platform/SinglePlatformView.tsxsrc/pages/ads/list/AdsListPage.tsxsrc/pages/ads/list/CampaignDetail.tsxsrc/pages/ads/new/CampaignGroup.tsxsrc/pages/integration/PlatformIntegrationsPage.tsx
jjjsun
approved these changes
Jul 30, 2026
This was referenced Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚨 관련 이슈
close #310
✨ 변경사항
✏️ 작업 내용
다시 시도표시AreaErrorFallback추가 — 표·드롭다운·카드 등 차트가 아닌 영역용 (이 영역을 불러오지 못했어요)ChartErrorFallback→AreaErrorFallback으로 교체😅 미완성 작업
N/A
📢 논의 사항 및 참고 사항
N/A
Summary by CodeRabbit