[Feature/#333] 멤버 알림 설정 목록 UI 및 GET API 연동 - #346
Conversation
|
Warning Review limit reached
Next review available in: 52 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough멤버 알림 설정 조회 API와 커서 기반 무한 조회 훅을 추가하고, 멤버 관리 화면에서 이메일별 수신 상태를 매핑해 벨 아이콘과 로딩·오류 상태로 표시하도록 연결했습니다. Changes멤버 알림 설정 조회
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant MemberManagement
participant useNotificationMembers
participant getNotificationMembers
participant MemberList
participant MemberItem
MemberManagement->>useNotificationMembers: 조직 ID로 알림 멤버 조회
useNotificationMembers->>getNotificationMembers: cursor 포함 페이지 요청
getNotificationMembers-->>useNotificationMembers: 알림 멤버 데이터 반환
useNotificationMembers-->>MemberManagement: 페이지와 다음 cursor 전달
MemberManagement->>MemberList: 이메일별 수신 상태와 쿼리 상태 전달
MemberList->>MemberItem: 멤버별 isReceive 전달
MemberItem-->>MemberList: 수신/미수신 아이콘 렌더링
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
📚 Storybook 배포 완료
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
src/components/workspace/MemberList.tsx (1)
26-28: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value컴포넌트 props 타입을
I*Props규칙으로 통일해 주세요.
src/components/workspace/MemberList.tsx#L26-L28:TMemberListProps를IMemberListProps로 변경하세요.src/components/workspace/MemberItem.tsx#L16-L22:TProps를IMemberItemProps로 변경하세요.As per coding guidelines, "component props use
I*Props."🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/components/workspace/MemberList.tsx` around lines 26 - 28, Rename the component props type TMemberListProps to IMemberListProps in src/components/workspace/MemberList.tsx (lines 26-28) and update all references. Rename TProps to IMemberItemProps in src/components/workspace/MemberItem.tsx (lines 16-22) and update all references, preserving the existing props structure and behavior.Source: Coding guidelines
src/components/workspace/MemberItem.tsx (1)
8-8: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value상대 경로 import를 alias로 변경해 주세요.
-import MemberRoleSelect from "./MemberRoleSelect"; +import MemberRoleSelect from "`@/components/workspace/MemberRoleSelect`";As per coding guidelines, "Use
@/alias for all imports."🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/components/workspace/MemberItem.tsx` at line 8, Update the MemberRoleSelect import in MemberItem.tsx to use the configured `@/` alias instead of the relative path, preserving the existing imported symbol and behavior.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/pages/workspace/MemberManagement.tsx`:
- Around line 318-320: Update the notification loading prop passed to the member
item near notificationReceiveByEmail so it combines
notificationMembersQuery.isLoading and
notificationMembersQuery.isFetchingNextPage. Preserve
notificationMembersQuery.isError unchanged, ensuring the notification icon
remains in a loading state during both initial and next-page requests.
---
Nitpick comments:
In `@src/components/workspace/MemberItem.tsx`:
- Line 8: Update the MemberRoleSelect import in MemberItem.tsx to use the
configured `@/` alias instead of the relative path, preserving the existing
imported symbol and behavior.
In `@src/components/workspace/MemberList.tsx`:
- Around line 26-28: Rename the component props type TMemberListProps to
IMemberListProps in src/components/workspace/MemberList.tsx (lines 26-28) and
update all references. Rename TProps to IMemberItemProps in
src/components/workspace/MemberItem.tsx (lines 16-22) and update all references,
preserving the existing props structure and behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: cd54b3da-6453-4445-a646-4db15067301f
⛔ Files ignored due to path filters (2)
src/assets/icon/common/bell-off.svgis excluded by!**/*.svgand included bysrc/**src/assets/icon/common/bell-ringing.svgis excluded by!**/*.svgand included bysrc/**
📒 Files selected for processing (6)
src/api/notification/notification.tssrc/components/workspace/MemberItem.tsxsrc/components/workspace/MemberList.tsxsrc/hooks/setting/useNotificationMembers.tssrc/lib/queryKeys.tssrc/pages/workspace/MemberManagement.tsx
2 participants
🚨 관련 이슈
Closed #333
✨ 변경사항
✏️ 작업 내용
GET /api/notification/settings/{orgId}/membersAPI/queryKey/훅 추가 및 연동🖥️ 작업 화면
알람 수신시
알람 미수신시
😅 미완성 작업
N/A
📢 논의 사항 및 참고 사항
Summary by CodeRabbit