Skip to content

[Bugfix/#341] 배포 환경 로그인 불가 수정 및 auth 방어 코드 보완 - #342

Merged
Seojegyeong merged 2 commits into
developfrom
bugfix/#341
Jul 29, 2026
Merged

Seojegyeong merged 2 commits into
developfrom
bugfix/#341

Conversation

@Seojegyeong

@Seojegyeong Seojegyeong commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

🚨 관련 이슈

#341

✨ 변경사항

  • 🐞 BugFix Something isn't working
  • 💻 CrossBrowsing Browser compatibility
  • 🌏 Deploy Deploy
  • 🎨 Design Markup & styling
  • 📃 Docs Documentation writing and editing (README.md, etc.)
  • ✨ Feature Feature
  • 🔨 Refactor Code refactoring
  • ⚙️ Setting Development environment setup
  • ✅ Test Test related (storybook, jest, etc.)

✏️ 작업 내용

  • .env.production 삭제 - 환경변수는 GitHub Secrets에서만 관리
  • useTokenRefresh.ts - reissue 응답 data?.accessToken optional chaining 추가
  • useAuthStore.ts - logout() 시 isTokenInitialized: false 초기화
  • axiosInstance.ts - 401 인터셉터 reissue 후 accessToken null 체크 추가
  • ci.yaml — Create .env file step 추가 (Lighthouse CI NO_FCP 수정)

.env.production이 존재했던 이유
CloudFront behavior로 /api/*를 백엔드에 라우팅하는 구조를 의도하여 생성한 파일임. 해당 방식이라면 VITE_API_BASE_URL=/로 same-origin 요청만 해도 동작하기 때문.
그러나 실제 아키텍처는 api.whereyouad.com 별도 도메인으로 백엔드를 분리하는 구조여서 값이 맞지 않았음. .env.production을 삭제하고 GitHub Secret으로 전체 URL을 주입하는 방식으로 통일함.

😅 미완성 작업

N/A

📢 논의 사항 및 참고 사항

N/A

💬 리뷰어 가이드 (P-Rules)
P1: 필수 반영 (Critical) - 버그 가능성, 컨벤션 위반. 해결 전 머지 불가.
P2: 적극 권장 (Recommended) - 더 나은 대안 제시. 가급적 반영 권장.
P3: 제안 (Suggestion) - 아이디어 공유. 반영 여부는 드라이버 자율.
P4: 단순 확인/칭찬 (Nit) - 사소한 오타, 칭찬 등 피드백.

- .env.production 삭제 — GitHub Secret 주입값이 무시되던 문제 해결
- useTokenRefresh: data?.accessToken optional chaining 추가
- useAuthStore: logout 시 isTokenInitialized 초기화
- axiosInstance: reissue 응답 accessToken null 체크 추가
@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@Seojegyeong, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 20 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: d168064f-a71e-4fc1-92cd-7b565e935928

📥 Commits

Reviewing files that changed from the base of the PR and between c48a187 and 739989e.

⛔ Files ignored due to path filters (2)
  • .env.production is excluded by none and included by none
  • .github/workflows/ci.yaml is excluded by none and included by none
📒 Files selected for processing (3)
  • src/hooks/auth/useTokenRefresh.ts
  • src/lib/axiosInstance.ts
  • src/store/useAuthStore.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bugfix/#341

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jul 28, 2026

Copy link
Copy Markdown

📚 Storybook 배포 완료

항목 링크
📖 Storybook https://69a147b60a56365d9e2185ef-arhryljhfg.chromatic.com/
🔍 Chromatic https://www.chromatic.com/build?appId=69a147b60a56365d9e2185ef&number=472

@YermIm YermIm left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P4: 확인했습니다!

@Seojegyeong
Seojegyeong merged commit f9fee83 into develop Jul 29, 2026
3 checks passed
@Seojegyeong
Seojegyeong deleted the bugfix/#341 branch July 29, 2026 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐞 BugFix Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐞 [BugFix] 배포 환경 로그인 불가 - .env.production VITE_API_BASE_URL 오설정 및 auth 방어 코드 누락

2 participants