Skip to content

[Refactor/#277] Lighthouse CI 임계값 warn → error 상향 - #320

Merged
Seojegyeong merged 2 commits into
developfrom
refactor/#277
Jul 27, 2026
Merged

Seojegyeong merged 2 commits into
developfrom
refactor/#277

Conversation

@Seojegyeong

Copy link
Copy Markdown
Collaborator

🚨 관련 이슈

#277

✨ 변경사항

  • 🐞 BugFix Something isn't working
  • 💻 CrossBrowsing Browser compatibility
  • 🌏 Deploy Deploy
  • 🎨 Design Markup & styling
  • 📃 Docs Documentation writing and editing (README.md, etc.)
  • ✨ Feature Feature
  • 🔨 Refactor Code refactoring
  • ⚙️ Setting Development environment setup
  • ✅ Test Test related (storybook, jest, etc.)

✏️ 작업 내용

  • perf/no-skeleton 임시 브랜치에서 OverviewDashboard · PlatformDashboard Skeleton 제거 후 BEFORE 수치 측정
  • main 브랜치에서 AFTER 수치 측정 (Skeleton 적용 상태)
  • lighthouserc.cjs 임계값 warn → error 상향 및 실측값 기반으로 확정

측정 결과 (Desktop / Navigation / /dashboard 3회 평균)

지표 BEFORE (Skeleton 없음) AFTER (Skeleton 적용) 변화
LCP 1180ms 1048ms -132ms (-11%) ✅
CLS 0.000172 0.000304 +0.000132
TBT 54ms 54ms 변화 없음

확정된 Lighthouse CI 임계값

지표 임계값 기준
LCP 2000ms AFTER 평균 1048ms × 2배 마진
CLS 0.1 실측값 0.000304로 사실상 0 수준
TBT 200ms AFTER 평균 54ms × 2배 마진

😅 미완성 작업

N/A

📢 논의 사항 및 참고 사항

CLS가 BEFORE보다 AFTER에서 소폭 증가(0.000172 → 0.000304)한 것은 Skeleton → 실제 콘텐츠 전환 시 미세한 레이아웃 이동이 발생하기 때문.
두 값 모두 0.1 기준 대비 사실상 0 수준이므로 실사용자 체감 영향 없음.

💬 리뷰어 가이드 (P-Rules)
P1: 필수 반영 (Critical) - 버그 가능성, 컨벤션 위반. 해결 전 머지 불가.
P2: 적극 권장 (Recommended) - 더 나은 대안 제시. 가급적 반영 권장.
P3: 제안 (Suggestion) - 아이디어 공유. 반영 여부는 드라이버 자율.
P4: 단순 확인/칭찬 (Nit) - 사소한 오타, 칭찬 등 피드백.

@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • lighthouserc.cjs is excluded by none and included by none

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: a1327d03-8155-44e4-bb59-d0c9d148626a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/#277

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Seojegyeong Seojegyeong self-assigned this Jul 27, 2026
@Seojegyeong
Seojegyeong requested review from YermIm and jjjsun July 27, 2026 01:24
@github-actions

github-actions Bot commented Jul 27, 2026

Copy link
Copy Markdown

📚 Storybook 배포 완료

항목 링크
📖 Storybook https://69a147b60a56365d9e2185ef-jpblvmksef.chromatic.com/
🔍 Chromatic https://www.chromatic.com/build?appId=69a147b60a56365d9e2185ef&number=440

@jjjsun jjjsun left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P4: 확인헀습니다!

@Seojegyeong
Seojegyeong merged commit 9b6dc9e into develop Jul 27, 2026
3 checks passed
@Seojegyeong
Seojegyeong deleted the refactor/#277 branch July 27, 2026 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

♻️ [Refactor] Skeleton UI 성능 개선 수치 측정 및 Lighthouse CI 임계값 적용

2 participants