Skip to content

[Bugfix/#249] 사이드바 아이콘 스타일 통일 및 접기 버튼 호버 크기 조정 - #262

Merged
Seojegyeong merged 1 commit into
developfrom
bugfix/#249
Jun 24, 2026
Merged

[Bugfix/#249] 사이드바 아이콘 스타일 통일 및 접기 버튼 호버 크기 조정#262
Seojegyeong merged 1 commit into
developfrom
bugfix/#249

Conversation

@Seojegyeong

@Seojegyeong Seojegyeong commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

🚨 관련 이슈

#249

✨ 변경사항

  • 🐞 BugFix Something isn't working
  • 💻 CrossBrowsing Browser compatibility
  • 🌏 Deploy Deploy
  • 🎨 Design Markup & styling
  • 📃 Docs Documentation writing and editing (README.md, etc.)
  • ✨ Feature Feature
  • 🔨 Refactor Code refactoring
  • ⚙️ Setting Development environment setup
  • ✅ Test Test related (storybook, jest, etc.)

✏️ 작업 내용

  • 기존 사이드바 네비게이션 아이콘의 SVG 속성이 아이콘마다 달라 굵기·크기가 들쭉날쭉해 보이는 문제가 있었고, 접기 버튼 호버 영역도 위쪽 아이콘과 맞지 않았음
  • 사이드바 아이콘 SVG 통일
    - viewBox="0 0 24 24"
    - stroke="currentColor", stroke-width="1.5"
    - stroke-linecap="round", stroke-linejoin="round"
    - ads는 fill 기반 디자인이라서 원본 유지
  • 사이드바 접기 버튼 호버 크기 조정: 접힌 상태에서 호버 박스가 위쪽 네비 아이콘과 동일한 55×55 크기로 보이도록 맞춤.

Before & After

image image

😅 미완성 작업

N/A

📢 논의 사항 및 참고 사항

N/A

💬 리뷰어 가이드 (P-Rules)
P1: 필수 반영 (Critical) - 버그 가능성, 컨벤션 위반. 해결 전 머지 불가.
P2: 적극 권장 (Recommended) - 더 나은 대안 제시. 가급적 반영 권장.
P3: 제안 (Suggestion) - 아이디어 공유. 반영 여부는 드라이버 자율.
P4: 단순 확인/칭찬 (Nit) - 사소한 오타, 칭찬 등 피드백.

Summary by CodeRabbit

  • 스타일
    • 사이드바 토글 버튼의 레이아웃과 크기를 조정했습니다. 버튼의 높이 및 정렬 속성이 개선되어 더 일관된 사용자 인터페이스를 제공합니다.

@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 13911caa-9cec-46fe-84ba-f46d2e34c8f0

📥 Commits

Reviewing files that changed from the base of the PR and between ad295b6 and c4146d3.

⛔ Files ignored due to path filters (3)
  • src/assets/icon/sidebar/connect.svg is excluded by !**/*.svg and included by src/**
  • src/assets/icon/sidebar/dashboard.svg is excluded by !**/*.svg and included by src/**
  • src/assets/icon/sidebar/workspace.svg is excluded by !**/*.svg and included by src/**
📒 Files selected for processing (1)
  • src/components/sidebar/Sidebar.tsx

📝 Walkthrough

Walkthrough

Sidebar.tsx의 하단 토글 버튼 className이 수정되었습니다. inline-flex h-14에서 flex h-[55px]로 변경되고, isCollapsed 상태에 따른 너비·정렬·패딩 조건부 클래스가 조정되었습니다. 버튼 로직 및 핸들러에는 변경이 없습니다.

Changes

사이드바 토글 버튼 스타일 변경

Layer / File(s) Summary
토글 버튼 className 업데이트
src/components/sidebar/Sidebar.tsx
inline-flex h-14flex h-[55px]로 변경되고, isCollapsed 분기에 따른 mx-auto w-[55px] justify-center px-0 또는 w-full gap-4 px-3 클래스 적용 방식이 구체화되었습니다.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

🎨 Html&css

Suggested reviewers

  • jjjsun
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The PR title clearly describes the main changes: sidebar icon style unification and collapse button hover size adjustment, directly matching the file modifications in Sidebar.tsx.
Description check ✅ Passed The PR description follows the template structure with all key sections completed: related issue (#249), change type (BugFix), detailed work content with specific SVG attributes and measurements, before/after screenshots, and notes on incomplete work (N/A).
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bugfix/#249

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Seojegyeong Seojegyeong self-assigned this Jun 24, 2026
@Seojegyeong
Seojegyeong requested review from YermIm and jjjsun June 24, 2026 03:20
@Seojegyeong Seojegyeong added 🎨 Html&css 마크업 & 스타일링 🐞 BugFix Something isn't working labels Jun 24, 2026
@github-actions

Copy link
Copy Markdown

📚 Storybook 배포 완료

항목 링크
📖 Storybook https://69a147b60a56365d9e2185ef-vjrckovpth.chromatic.com/
🔍 Chromatic https://www.chromatic.com/build?appId=69a147b60a56365d9e2185ef&number=354

@jjjsun jjjsun left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P4: 확인했습니다! 고생하셨어요!

@Seojegyeong
Seojegyeong merged commit 6ce7c60 into develop Jun 24, 2026
3 checks passed
@Seojegyeong
Seojegyeong deleted the bugfix/#249 branch June 24, 2026 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐞 BugFix Something isn't working 🎨 Html&css 마크업 & 스타일링

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐞 [BugFix] 사이드바 아이콘 SVG 두께·크기·스타일 불일치 수정

2 participants