-
Notifications
You must be signed in to change notification settings - Fork 1
[Refactor/#229] Overview&Platform 중복 통합 #245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
72ba2cf
refactor: IRoasRanking 타입을 provider.ts로 통합
Seojegyeong 8a84416
refactor: 공통 dashboard 타입을 common.ts로 분리
Seojegyeong 332bef6
refactor: IBudgetsResponse/IBudgetStatus를 IBudgetResponse로 통합
Seojegyeong e46b561
refactor: useOverviewBudget/usePlatformBudget를 useBudget으로 통합
Seojegyeong 4cd1892
refactor: KPI 변환 로직을 metricsToKpis 유틸로 통합
Seojegyeong b47597b
refactor: 플랫폼 circle 로고 맵을 PLATFORM_CIRCLE_LOGO_MAP 상수로 추출
Seojegyeong a31f4c4
style: 플랫폼 로고 크기 h-8 w-8으로 통일
Seojegyeong 9f0f161
style: rounded-[24px]를 Tailwind 토큰 rounded-3xl로 교체
Seojegyeong 2feeb92
refactor: minute 문자열 파싱 로직을 parseMinuteToTimestamp 유틸로 추출
Seojegyeong c25d9cd
style: 불필요한 주석 제거
Seojegyeong d5334cc
refactor: AllPlatformTrafficChart parseMinuteToTimestamp 적용, usePlatf…
Seojegyeong 1d2b586
fix: provider 키 정규화 및 parseMinuteToTimestamp 유효성 검증 추가, 장식용 로고 aria-h…
Seojegyeong 72e0bc6
style: rounded-[24px]를 Tailwind 토큰 rounded-3xl로 교체
Seojegyeong d9ed691
Merge remote-tracking branch 'origin/develop' into refactor/#229
Seojegyeong File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| import type React from "react"; | ||
|
|
||
| import type { TProviderType } from "@/types/dashboard/provider"; | ||
|
|
||
| import GoogleLogo from "@/assets/logo/social-logo/circle/google-circle.svg?react"; | ||
| import MetaLogo from "@/assets/logo/social-logo/circle/meta-circle.svg?react"; | ||
| import NaverLogo from "@/assets/logo/social-logo/circle/naver-circle.svg?react"; | ||
|
|
||
| export const PLATFORM_CIRCLE_LOGO_MAP: Record< | ||
| TProviderType, | ||
| React.FC<React.SVGProps<SVGSVGElement>> | ||
| > = { | ||
| GOOGLE: GoogleLogo, | ||
| NAVER: NaverLogo, | ||
| META: MetaLogo, | ||
| }; |
14 changes: 9 additions & 5 deletions
14
src/hooks/dashboard/useOverviewBudget.ts → src/hooks/dashboard/useBudget.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.