Skip to content

[Refactor/#167] 헤더 로그인/회원가입 버튼 추가 + 온보딩 페이지 제거 - #168

Merged
Seojegyeong merged 10 commits into
developfrom
refactor/#167
May 4, 2026
Merged

[Refactor/#167] 헤더 로그인/회원가입 버튼 추가 + 온보딩 페이지 제거#168
Seojegyeong merged 10 commits into
developfrom
refactor/#167

Conversation

@Seojegyeong

@Seojegyeong Seojegyeong commented May 3, 2026

Copy link
Copy Markdown
Collaborator

🚨 관련 이슈

#165

✨ 변경사항

  • 🐞 BugFix Something isn't working
  • 💻 CrossBrowsing Browser compatibility
  • 🌏 Deploy Deploy
  • 🎨 Design Markup & styling
  • 📃 Docs Documentation writing and editing (README.md, etc.)
  • ✨ Feature Feature
  • 🔨 Refactor Code refactoring
  • ⚙️ Setting Development environment setup
  • ✅ Test Test related (storybook, jest, etc.)

✏️ 작업 내용

  • 랜딩 페이지 세부 색감 변경 및 로고 적용
  • 헤더 상단 로그인, 회원가입 CTA 버튼 추가(Hero section과 중복되어 Hero에서는 제거)
  • AuthLayout에서 좌측 온보딩(소개) 컬럼을 제거하고, Outlet만 뷰포트 가운데에 오도록 정리
  • OnboardingIntro 및 src/components/auth/intro/ 하위 컴포넌트 삭제.

스크린샷

CaptureX_2026-05-04_132147_localhost CaptureX_2026-05-04_132209_localhost CaptureX_2026-05-04_132227_localhost CaptureX_2026-05-04_132246_localhost

😅 미완성 작업

N/A

📢 논의 사항 및 참고 사항

N/A

💬 리뷰어 가이드 (P-Rules)
P1: 필수 반영 (Critical) - 버그 가능성, 컨벤션 위반. 해결 전 머지 불가.
P2: 적극 권장 (Recommended) - 더 나은 대안 제시. 가급적 반영 권장.
P3: 제안 (Suggestion) - 아이디어 공유. 반영 여부는 드라이버 자율.
P4: 단순 확인/칭찬 (Nit) - 사소한 오타, 칭찬 등 피드백.

- AuthLayout에서 좌측 온보딩 컬럼 제거, Outlet만 뷰포트 중앙 배치
- OnboardingIntro 및 intro 컴포넌트 삭제
- 로그인·회원가입·비밀번호·이메일 찾기 등 폼 루트 max-width·mx-auto 및 제목 text-center 정리
- 인증 스켈레톤 레이아웃 동일하게 맞춤
@Seojegyeong Seojegyeong self-assigned this May 3, 2026
@coderabbitai

coderabbitai Bot commented May 3, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@Seojegyeong has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 50 minutes before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 78ae28ba-5c7e-404d-a7fd-4ffaac15ff2d

📥 Commits

Reviewing files that changed from the base of the PR and between 8aebcca and 903de80.

⛔ Files ignored due to path filters (12)
  • .gitignore is excluded by none and included by none
  • index.html is excluded by none and included by none
  • public/logo.svg is excluded by !**/*.svg and included by none
  • src/assets/icon/common/check-white.svg is excluded by !**/*.svg and included by src/**
  • src/assets/icon/common/copy.svg is excluded by !**/*.svg and included by src/**
  • src/assets/icon/common/edit.svg is excluded by !**/*.svg and included by src/**
  • src/assets/icon/common/userProfile.svg is excluded by !**/*.svg and included by src/**
  • src/assets/logo/service-logo/logo-mark-white.svg is excluded by !**/*.svg and included by src/**
  • src/assets/logo/service-logo/logo-mark.svg is excluded by !**/*.svg and included by src/**
  • src/assets/logo/service-logo/logo.svg is excluded by !**/*.svg and included by src/**
  • src/assets/mockup/iOS app dock.png is excluded by !**/*.png and included by src/**
  • src/assets/mockup/logo_test/logo_2.png is excluded by !**/*.png and included by src/**
📒 Files selected for processing (26)
  • src/components/auth/common/AuthFormShell.tsx
  • src/components/auth/common/PasswordForm.tsx
  • src/components/auth/flows/find-email/EnterPhoneStep.tsx
  • src/components/auth/flows/find-email/ShowEmailResultStep.tsx
  • src/components/auth/flows/reset-password/EmailVerificationStep.tsx
  • src/components/auth/flows/signup/EnterEmailStep.tsx
  • src/components/auth/flows/signup/ProfileSetupStep.tsx
  • src/components/auth/intro/AiTalkBubble.tsx
  • src/components/auth/intro/IntroAIAnalytics.tsx
  • src/components/auth/intro/IntroAdManagement.tsx
  • src/components/auth/intro/IntroLogo.tsx
  • src/components/auth/intro/OnboardingIntro.tsx
  • src/components/auth/skeleton/AuthFormSkeleton.tsx
  • src/components/auth/skeleton/LoginPageSkeleton.tsx
  • src/components/auth/skeleton/SignupEmailStepSkeleton.tsx
  • src/components/auth/skeleton/SignupPageSkeleton.tsx
  • src/components/landing/LandingFooter.tsx
  • src/components/landing/LandingHeader.tsx
  • src/components/landing/LandingHero.tsx
  • src/components/landing/LandingMultiDevice.tsx
  • src/components/landing/LandingPricing.tsx
  • src/index.css
  • src/layout/auth/AuthLayout.tsx
  • src/pages/auth/Login.tsx
  • src/pages/auth/Signup.tsx
  • src/pages/landing/LandingPage.tsx
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/#167

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 50 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

온보딩 제거 시 적용했던 text-center를 text-start로 되돌려 기존 UI와 맞춤.
@github-actions

github-actions Bot commented May 3, 2026

Copy link
Copy Markdown

📚 Storybook 배포 완료

항목 링크
📖 Storybook https://69a147b60a56365d9e2185ef-ylktsddrnz.chromatic.com/
🔍 Chromatic https://www.chromatic.com/build?appId=69a147b60a56365d9e2185ef&number=222

@Seojegyeong
Seojegyeong requested review from YermIm and jjjsun May 3, 2026 14:09
- AuthFormShell로 인증 폼 max-width·패딩 통일, 스켈레톤 정렬을 실제 화면과 맞춤
- 로그인 화면 제목만 가운데 정렬
- 랜딩 헤더 회원가입 링크에서 step=1 제거, 소셜·이메일 시작 화면부터 진입
- 체크박스 아이콘 경로 수정 및 check-white.svg 추가, 미사용 에셋 정리
- 로컬용 strip 스크립트 gitignore, Sidebar 불필요 주석 제거
@Seojegyeong Seojegyeong added 🎨 Html&css 마크업 & 스타일링 🔨 Refactor 코드 리팩토링 labels May 4, 2026
@jjjsun

jjjsun commented May 4, 2026

Copy link
Copy Markdown
Collaborator

P4: 확인했습니다!

@Seojegyeong
Seojegyeong merged commit ff407a3 into develop May 4, 2026
3 checks passed
@Seojegyeong
Seojegyeong deleted the refactor/#167 branch May 4, 2026 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🎨 Html&css 마크업 & 스타일링 🔨 Refactor 코드 리팩토링

Projects

None yet

Development

Successfully merging this pull request may close these issues.

♻️ [Refactor] 헤더 로그인/회원가입 버튼 추가 + 온보딩 페이지 제거

2 participants