[Refactor/#109] AI 요약 버튼 및 모달 개선 - #112
Conversation
📝 WalkthroughWalkthrough드로어의 태블릿 UI 코너 라운딩을 조정하고, 예산 차트의 기간 계산 로직을 제거하며 메시지 판정을 단순화했습니다. 또한 새로운 스파클 펄스 애니메이션 유틸리티를 추가했습니다. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
📚 Storybook 배포 완료
|
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/components/dashboard/charts/BudgetGaugeChart.tsx (1)
121-123: 초과 상태에서도 라벨이 ‘남은 예산’으로 고정되어 의미가 헷갈릴 수 있습니다.
isOverBudget일 때 값은 음수 표현인데 라벨은 그대로라서, 사용자 입장에서 해석 비용이 생깁니다. 상태에 따라 라벨을 동적으로 바꿔주면 더 명확합니다.제안 diff
- <span className="font-caption font-medium text-text-auth-sub"> - 남은 예산 - </span> + <span className="font-caption font-medium text-text-auth-sub"> + {isOverBudget ? "초과 예산" : "남은 예산"} + </span>Also applies to: 130-130
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/components/dashboard/charts/BudgetGaugeChart.tsx` around lines 121 - 123, The label “남은 예산” in BudgetGaugeChart is confusing when isOverBudget is true because the displayed value becomes negative; update the JSX to render a dynamic label based on the isOverBudget flag (e.g., isOverBudget ? '초과 금액' or '초과' : '남은 예산') so the label matches the state, and apply this change to both occurrences of the span with className "font-caption font-medium text-text-auth-sub" (the two places around the budget display).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/components/dashboard/charts/BudgetGaugeChart.tsx`:
- Around line 72-74: The visual title currently rendered as a <span> in the
BudgetGaugeChart component should be a semantic heading for accessibility;
replace the <span className="font-body2 font-semibold text-text-auth-sub
mb-3">사용 예산</span> with an appropriate heading element (e.g., <h3>) preserving
the existing className and styling, and ensure the heading level chosen fits the
page structure (adjust to h2/h4 if needed) so screen readers treat it as a real
heading; update any tests or snapshots that assert this element if present.
---
Nitpick comments:
In `@src/components/dashboard/charts/BudgetGaugeChart.tsx`:
- Around line 121-123: The label “남은 예산” in BudgetGaugeChart is confusing when
isOverBudget is true because the displayed value becomes negative; update the
JSX to render a dynamic label based on the isOverBudget flag (e.g., isOverBudget
? '초과 금액' or '초과' : '남은 예산') so the label matches the state, and apply this
change to both occurrences of the span with className "font-caption font-medium
text-text-auth-sub" (the two places around the budget display).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 6b4c3348-2633-4df6-90d7-d7163890d71b
⛔ Files ignored due to path filters (3)
ai-button-preview.htmlis excluded by none and included by nonesrc/assets/icon/chevron/chevron-right.svgis excluded by!**/*.svgand included bysrc/**src/assets/logo/service-logo/ai-요약버튼.svgis excluded by!**/*.svgand included bysrc/**
📒 Files selected for processing (3)
src/components/common/drawer/Drawer.tsxsrc/components/dashboard/charts/BudgetGaugeChart.tsxsrc/index.css
|
P4: 확인했습니다!! 수고하셨어요 :) |
🚨 관련 이슈
#109
✨ 변경사항
✏️ 작업 내용
2026-03-20.10.30.28.mov
😅 미완성 작업
N/A
📢 논의 사항 및 참고 사항
N/A
Summary by CodeRabbit
릴리스 노트
새로운 기능
스타일