Include basic liveness & readiness probes #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include a HTTPS request to the root path (/) that returns a 200 OK and does not require a token to be requested.
|
Hi @palmerabollo! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thanks, bot. I'm not going to sign any CLA for this small contribution. Feel free to close the pull request and/or include the probes if you think they are useful. |
bmm-alc
added a commit
to bmm-alc/WhatsApp-Business-API-Setup-Scripts
that referenced
this pull request
Mar 7, 2023
Include a HTTPS request to the root path (/) that returns a 200 OK and does not require a token to be requested. patch from WhatsApp#48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include a HTTPS request to the root path (/) that returns a 200 OK and does not require a token to be requested.
This is important because, if the lighttpd server dies, the container keeps running and K8s never notices. You can reproduce this behavior by entering the container (e.g. kubectl exec -it xxxxx sh) and sending a kill -9 to the lighttpd process.
With this change, kubernetes notices the pod is no longer live > kill it > relaunch it and everything keeps running.