Enable SM86 MXFP4 sparse-indexer cache - #14
Merged
Conversation
added 3 commits
August 20, 2026 15:41
Assisted-by: OpenAI Codex Signed-off-by: Will Hampson <whamp@ggl.slmail.me>
Assisted-by: OpenAI Codex Signed-off-by: Will Hampson <whamp@ggl.slmail.me>
Preserve main's KV-cache spec promotion and relocated capacity logging while retaining the reviewed deterministic allocation report. Assisted-by: OpenAI Codex Signed-off-by: Will Hampson <whamp@ggl.slmail.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Merge the reviewed DeepSeek V4 SM86 FP4 KV-cache capacity work into fork
main:The new indexer format remains opt-in. FP8 remains the default because the capacity gain comes with measured prefill and throughput regressions and only 25-26 MiB/card headroom at the 200K functional ceiling.
Duplicate-work check
I searched open Whamp/vllm and upstream vllm-project/vllm issues/PRs for DeepSeek V4, FP4/MXFP4, sparse indexer, and SM86.
Related upstream work is materially different:
No open Whamp/vllm PR duplicates this branch.
Validation
Focused and regression evidence is checksum-bound under:
benchmarks/kernels/deepseek_v4/fp4_indexer_sm86/evidence/capacity_before_indexerbenchmarks/kernels/deepseek_v4/fp4_indexer_sm86/evidence/baseline_comparisonbenchmarks/kernels/deepseek_v4/fp4_indexer_sm86/evidence/after_indexerKey executed checks:
sm_86.verify-full.shpassed.verify-stress.shpassed with exact NIAH through 195,812 tokens at the 200K profile.The reviewed branch was merged with current fork
main; the only conflict was invllm/v1/core/kv_cache_utils.py. The resolution preservesmain's class-changing spec promotion and relocated capacity logging while retaining the reviewed allocation report. The post-resolution KV-cache suites pass 86/86.Measured outcome
At the 175K profile, MXFP4 indexer caching increased reported cache capacity from 178,050 to 202,260 tokens. The explicit 200K profile reports 199,409 tokens and passed exact NIAH at 195,812 prompt tokens.
Matched tradeoffs versus the FP8-indexer FP4 control:
Decision: retain as an explicit capacity experiment, not the default format.
Review and assistance
The change received independent standards/spec and kernel-safety review. Blocking findings were fixed, including unconditional architecture validation, optimized-Python rejection coverage, exact top-k/output tests,
clean_logits=Falsepaged tests, baseline provenance, and report claim corrections.REVIEW.mdrecords the review and unavailable GLM reviewer quota.AI assistance was used throughout implementation, diagnosis, testing, review synthesis, documentation, and merge-conflict resolution. The repository owner explicitly directed this merge into the Whamp fork.