ci: speedup build with caching #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wenzel
force-pushed
the
ci_speedup_with_cache
branch
from
a9e9413 to
c7a6355
Compare
| @@ -35,10 +35,20 @@ jobs: | |||
| toolchain: stable | |||
| components: clippy | |||
| - uses: actions/checkout@v1 | |||
|
|
|||
| - uses: actions/cache@v2 | |||
There was a problem hiding this comment.
Why though? Do you really need faster builds? This carries its own set of issues. For example, clippy does not work correctly on cached builds.
There was a problem hiding this comment.
you always want faster build when the build time is around 1 min or more, which is the case for rust projects
I wasn't aware that clippy would break with caching.
the idea was to speedup things like debian packaging (2 min) and release (4min).
the release job doesn't have a cache yet.
There was a problem hiding this comment.
TLDR: Clippy can only analyze code that is compiled during execution of cargo clippy. Since files that are up to date won't be rebuilt clippy will not report errors for those.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
speedup build with cache:
https://github.com/actions/cache/blob/main/examples.md#rust---cargo