Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unintended overwrite saving #516

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Fix unintended overwrite saving #516

merged 1 commit into from
Sep 19, 2024

Conversation

WenjieDu
Copy link
Owner

What does this PR do?

  1. fixing Unintended saving success when model file already exists #515;

Before submitting

  • Was this discussed/approved via a GitHub issue? Please add a link to it if that's the case.

@coveralls
Copy link
Collaborator

coveralls commented Sep 19, 2024

Pull Request Test Coverage Report for Build 10932379202

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 83.34%

Files with Coverage Reduction New Missed Lines %
pypots/imputation/csdi/model.py 1 84.85%
pypots/cli/doc.py 3 82.28%
Totals Coverage Status
Change from base Build 10833804335: -0.02%
Covered Lines: 11195
Relevant Lines: 13433

💛 - Coveralls

@WenjieDu WenjieDu merged commit 5263088 into dev Sep 19, 2024
9 checks passed
@WenjieDu WenjieDu deleted the (fix)saving_overwrite branch September 19, 2024 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants