Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc update Quickstart Example #497

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Conversation

eroell
Copy link
Contributor

@eroell eroell commented Aug 15, 2024

What does this PR do?

Fixing #496

This is fixing the mentioned issue with as minimal changes as possible, keeping the minimality of this example. But I've seen that in the notebook the imputaton example with saits has already been extended to newer releases from pypots and tsdb.

If this is helpful, feel free to modify the PR such that it is useful for your quickstart example. :) I'm aware that maybe load_specific_dataset could be changed to use BenchPOTS or so, but as this would make the example less minimal for now I refrained from doing so yet...

Best,

Before submitting

  • This PR is made to fix a typo or improve the docs (you can dismiss the other checks if this is the case).
  • Was this discussed/approved via a GitHub issue? Please add a link to it if that's the case.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have written necessary tests and already run them locally.

@WenjieDu WenjieDu merged commit ec508a6 into WenjieDu:main Aug 22, 2024
@eroell eroell mentioned this pull request Aug 22, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants