Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix saving failed when the strategy is 'better' #469

Merged
merged 1 commit into from
Jul 21, 2024
Merged

Conversation

WenjieDu
Copy link
Owner

What does this PR do?

  1. fixing Model saving bug #464;

Before submitting

  • Was this discussed/approved via a GitHub issue? Please add a link to it if that's the case.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have written necessary tests and already run them locally.

@coveralls
Copy link
Collaborator

coveralls commented Jul 21, 2024

Pull Request Test Coverage Report for Build 10025647409

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.035%

Totals Coverage Status
Change from base Build 10020935521: 0.0%
Covered Lines: 10580
Relevant Lines: 12590

💛 - Coveralls

@WenjieDu WenjieDu merged commit 5f1baa6 into dev Jul 21, 2024
9 checks passed
@WenjieDu WenjieDu deleted the (fix)model_saving branch July 21, 2024 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants