Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): bump mocha-phantomjs from 3.6.0 to 4.1.0 #21

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 3, 2022

Bumps mocha-phantomjs from 3.6.0 to 4.1.0.

Release notes

Sourced from mocha-phantomjs's releases.

v4.0 - direct dependency on phantomjs, no more mochaPhantomJS global

v4.0 is here and was originally intended to be the release to switch over to PhantomJS 2, but not all official linux binaries are out after 9 months after the original release (see Medium/phantomjs#288, ariya/phantomjs#12948, #175). However the core phantomjs code has been moved out to mocha-phantomjs-core which does support phantomjs2, so you can use phantomjs 2 with your test if you bring your own binary:

mocha-phantomjs -p /path/to/phantomjs2 tests/mytests.html

Not So Breaking Changes

"Not so" much as 95% of you won't notice anything and it will just work, but the first two will be nice improvements to do.

  1. mocha-phantomjs directly depends on phantomjs. You can remove phantomjs that you likely directly declared from #167 's need to cap phantomjs to 1.9.7-15, and it will install without errors or warning by avoiding the peerDependencies bag of hurt.
  2. mochaPhantomJS no longer exists. You can simply call mocha.run() as normal. If you were using this to detect phantomjs, please use 'callPhantom' in window instead.
  3. Due to the above, using RequireJS or another script load mocha is not supported. mocha always exposes globals anyways, so there is no benefit to this, as well as loading your tests with an AMD loader is just more work than script tags. Also I highly recommend using server side templating of your test HTML with tests from your test directory so you don't forget to include a new set of tests in your test run. However you can load your product and test code asynchronously, just not mocha itself.
  4. All the phantomjs code no longer lives in this repository, but in mocha-phantomjs-core. It was rewritten in plain JavaScript since PhantomJS 2 removed CofffeScript support and to support plugin authors to have more control (#175). Please keep this in mind when filing issues - anything related to phantomjs interaction, browser side bugs, etc. should go there.
  5. Errors are now logged to stderr #162.
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Aug 3, 2022
Bumps [mocha-phantomjs](https://github.com/nathanboktae/mocha-phantomjs) from 3.6.0 to 4.1.0.
- [Release notes](https://github.com/nathanboktae/mocha-phantomjs/releases)
- [Commits](nathanboktae/mocha-phantomjs@v3.6.0...v4.1.0)

---
updated-dependencies:
- dependency-name: mocha-phantomjs
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/mocha-phantomjs-4.1.0 branch from a2f6fc9 to ef423df Compare August 6, 2022 09:39
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 7, 2022

Looks like mocha-phantomjs is no longer a dependency, so this is no longer needed.

@dependabot dependabot bot closed this Aug 7, 2022
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/mocha-phantomjs-4.1.0 branch August 7, 2022 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants