Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3. Center map based on user location #164

Merged
merged 47 commits into from
Aug 18, 2021
Merged

Conversation

wardbeyens
Copy link
Member

No description provided.

@wardbeyens wardbeyens temporarily deployed to staging August 10, 2021 13:34 Inactive
@github-actions
Copy link

github-actions bot commented Aug 10, 2021

Visit the preview URL for this PR (updated for commit 883963f):

https://wtmg-dev--pr164-feature-user-locatio-r0wpy0fn.web.app

(expires Tue, 24 Aug 2021 12:38:13 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@wardbeyens wardbeyens temporarily deployed to staging August 10, 2021 15:00 Inactive
@wardbeyens wardbeyens temporarily deployed to staging August 10, 2021 15:04 Inactive
@jbelien
Copy link
Contributor

jbelien commented Aug 11, 2021

Quick feedback (requested by @Driesvanransbeeck):

  • When I accept to share my location (or when I search for a place), the map is only centered ; I think it also needs to zoom on your location (or the place your selected) ;
  • Location is only shared on page load, I would add a button to give the possibility to share its "new" location (will be useful is the website is used on the go) ;
  • What if the browser doesn't support the GeoLocation API ? That case doesn't seem to be handled ;
    if('geolocation' in navigator) {
      /* geolocation is available */
    } else {
      /* geolocation IS NOT available */
    }

This (quick) feedback is only focused on GeoLocation.
But I also noticed stuff that doesn't mean anything in the French translation file.

@auloin auloin temporarily deployed to staging August 11, 2021 12:45 Inactive
@auloin
Copy link
Collaborator

auloin commented Aug 11, 2021

Thanks @jbelien! We'll create separate issues for your first 2 suggestions.

When I accept to share my location (or when I search for a place), the map is only centered ; I think it also needs to zoom on your location (or the place your selected) ;

Location is only shared on page load, I would add a button to give the possibility to share its "new" location (will be useful is the website is used on the go) ;

@wardbeyens wardbeyens temporarily deployed to staging August 12, 2021 09:15 Inactive
@wardbeyens wardbeyens temporarily deployed to staging August 12, 2021 09:25 Inactive
@auloin auloin temporarily deployed to staging August 16, 2021 11:57 Inactive
@wardbeyens wardbeyens temporarily deployed to staging August 16, 2021 14:32 Inactive
@wardbeyens wardbeyens temporarily deployed to staging August 16, 2021 15:14 Inactive
@auloin auloin temporarily deployed to staging August 17, 2021 07:38 Inactive
@auloin auloin temporarily deployed to staging August 17, 2021 08:48 Inactive
@wardbeyens
Copy link
Member Author

Zoom seems to work fine!

@wardbeyens wardbeyens temporarily deployed to staging August 17, 2021 10:05 Inactive
@wardbeyens wardbeyens temporarily deployed to staging August 17, 2021 10:14 Inactive
@wardbeyens wardbeyens temporarily deployed to staging August 17, 2021 12:22 Inactive
@wardbeyens wardbeyens temporarily deployed to staging August 17, 2021 12:29 Inactive
@wardbeyens wardbeyens temporarily deployed to staging August 17, 2021 12:37 Inactive
@wardbeyens wardbeyens changed the base branch from feature/search-location to master August 18, 2021 07:34
@wardbeyens wardbeyens merged commit e0443ae into master Aug 18, 2021
@wardbeyens wardbeyens deleted the feature/user-location branch August 18, 2021 13:54
@wardbeyens wardbeyens linked an issue Aug 19, 2021 that may be closed by this pull request
4 tasks
@wardbeyens
Copy link
Member Author

closes #55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust center of the map based on the user
3 participants