Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Glossary support for Google Cloud Translation Advanced #10526

Closed
nijel opened this issue Dec 1, 2023 · 4 comments · Fixed by #12777
Closed

Glossary support for Google Cloud Translation Advanced #10526

nijel opened this issue Dec 1, 2023 · 4 comments · Fixed by #12777
Assignees
@gersona
Labels
backlog This is not on the Weblate roadmap for now. Can be prioritized by sponsorship. enhancement Adding or requesting a new feature. help wanted Extra attention is needed.
Milestone
5.9

Comments

@nijel
Copy link
Member

nijel commented Dec 1, 2023 •
edited
Loading

Describe the problem

Add glossaries support to Google Cloud Translation Advanced. Their documentation is at https://cloud.google.com/translate/docs/reference/rest/v3/projects.locations.glossaries, Python API is described at https://cloud.google.com/python/docs/reference/translate/latest/google.cloud.translate_v3.services.translation_service.TranslationServiceClient#google_cloud_translate_v3_services_translation_service_TranslationServiceClient_create_glossary.

Describe the solution you'd like

Add GlossaryMachineTranslationMixin to GoogleV3Translation, hook it to download_translations and implement missing methods.

Describe alternatives you've considered

No response

Screenshots

No response

Additional context
@nijel nijel added enhancement Adding or requesting a new feature. backlog This is not on the Weblate roadmap for now. Can be prioritized by sponsorship. labels Dec 1, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2023

This issue has been added to the backlog. It is not scheduled on the Weblate roadmap, but it eventually might be implemented.

In case you need this feature soon, please consider helping or push it by funding the development.

@nijel nijel added the help wanted Extra attention is needed. label Dec 1, 2023
@nijel nijel mentioned this issue Dec 1, 2023
Closed
@nijel nijel changed the title Glossary support Google Cloud Translation Advanced Glossary support for Google Cloud Translation Advanced Dec 1, 2023
@nijel nijel mentioned this issue Jul 5, 2024
Closed
2 tasks
@gersona
Copy link
Collaborator

gersona commented Oct 14, 2024 •
edited
Loading

@nijel the glossary feature requires a new bucket-name field. Does it have to be a mandatory field ? I mean, if it is not provided, should the automatic suggestion be disabled altogether (and the feature listed as a breaking change), or do we allow automatic suggestion to run normally but without the glossary ?

@nijel
Copy link
Member Author

nijel commented Oct 14, 2024

I think it should run without a glossary (storing glossaries will probably also lead to additional costs).

@gersona gersona mentioned this issue Oct 15, 2024
Merged
5 tasks
@nijel nijel added this to the 5.9 milestone Nov 2, 2024
nijel added a commit that referenced this issue Nov 13, 2024
@gersona @nijel
feat(machinery): Glossary support for Google Cloud Translation Advanc…
9b23330 
…ed (#12777)

* GoogleV3 Glossary support implementation
* handle multiple dependencies for show-extras
* Documentation update
* syntax error fix
* fix missing test coverage
* add bucket usage explanation
* "bucket_name" added to SettingsDict
* chore: lockfile maintenance

Fixes #10526

Co-authored-by: Michal Čihař <[email protected]>
@github-actions GitHub Actions
Copy link

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gersona gersona

Labels
backlog This is not on the Weblate roadmap for now. Can be prioritized by sponsorship. enhancement Adding or requesting a new feature. help wanted Extra attention is needed.
Projects
None yet
Milestone
5.9
Development

Successfully merging a pull request may close this issue.

Glossary support for Google Cloud Translation Advanced gersona/weblate
2 participants
@nijel @gersona