Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for defining localtime via volume #2828

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

nijel
Copy link
Member

@nijel nijel commented Nov 21, 2024

Proposed changes

Docker engine follows symlinks when creating the volume what makes /tmp/localtime read-only. But user has apparently configured timezone in this case so we can skip this step.

Checklist

  • Lint and unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added documentation to describe my feature.
  • I have squashed my commits into logic units.
  • I have described the changes in the commit messages.

Other information

@FSeidinger-XI This should fix your issue.

Docker engine follows symlinks when creating the volume what makes /tmp/localtime
read-only. But user has apparently configured timezone in this case so we can
skip this step.
@nijel nijel merged commit f11f2f4 into WeblateOrg:main Nov 21, 2024
37 checks passed
@nijel nijel deleted the localtime branch November 21, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant