Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add /tmp and /run volumes" #2821

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Conversation

nijel
Copy link
Member

@nijel nijel commented Nov 20, 2024

Proposed changes

This reverts commit 384b4de.

These volumes are only intended to be used as tmpfs, but when adding them as VOLUME in Dockerfile, these will end up as real volumes in the swarm mode.

Fixes #2816

Checklist

  • Lint and unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added documentation to describe my feature.
  • I have squashed my commits into logic units.
  • I have described the changes in the commit messages.

Other information

This reverts commit 384b4de.

These volumes are only intended to be used as tmpfs, but when adding
them as VOLUME in Dockerfile, these will end up as real volumes in the
swarm mode.

Fixes WeblateOrg#2816
@nijel nijel self-assigned this Nov 20, 2024
@nijel nijel enabled auto-merge (rebase) November 20, 2024 08:59
@nijel nijel merged commit 0b02c62 into WeblateOrg:main Nov 20, 2024
36 checks passed
@nijel nijel deleted the drop-tmpfs-volumes branch November 20, 2024 09:18
@FSeidinger-XI
Copy link

Dear Michael,

I've send you a PM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weblate cannot start container in docker swarm mode
2 participants